gitpod
gitpod copied to clipboard
Fix context missing for test cases
Description
There're some places will print mismatch
authorizaer: it's testing mismatch casesorganization-service: testing PERMISSION_DENIED / NOT_FOUND (i.e. member update settings, stranger find org)
Important logic change:
organization-service:addOrUpdateMemberwith a new owner it will delete BUILT_IN one from org, add arunWithSubjectIdto make sure it's the new owner going to delete the member.workspace-starter:failInstanceStartit can happend no instance (at least in test case)
Others
bearer-authxxx.spec.ts: logic of expectError is not complete- Test cases to create orgniaztion via BUILT IN users, first joiner should be owner
Related Issue(s)
Fixed [internal chat]
How to test
Check changes of test cases (there're some note for changes on the Description section)
- Run test in server
- Should have no error like
SubjectId mismatchexcept what described on PR Description section
Documentation
Preview status
gitpod:summary
Build Options
Build
- [ ] /werft with-werft Run the build with werft instead of GHA
- [ ] leeway-no-cache
- [ ] /werft no-test
Run Leeway with
--dont-test
Publish
- [ ] /werft publish-to-npm
- [ ] /werft publish-to-jb-marketplace
Installer
- [ ] analytics=segment
- [ ] with-dedicated-emulation
- [ ] workspace-feature-flags Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
- [ ] /werft with-local-preview
If enabled this will build
install/preview - [ ] /werft with-preview
- [ ] /werft with-large-vm
- [x] /werft with-gce-vm If enabled this will create the environment on GCE infra
- [x] /werft preemptible Saves cost. Untick this only if you're really sure you need a non-preemtible machine.
- [ ] with-integration-tests=all
Valid options are
all,workspace,webapp,ide,jetbrains,vscode,ssh. If enabled,with-previewandwith-large-vmwill be enabled. - [ ] with-monitoring
/hold
Sorry @mustard-mh , did manage to overlook this one. Will take a look this afternoon :bow:
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
@mustard-mh Ugh, I did miss this PR again :sob:
I blocked some time early next week to look into that, incl. this PR. :date:
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.