gitpod icon indicating copy to clipboard operation
gitpod copied to clipboard

Fix context missing for test cases

Open mustard-mh opened this issue 1 year ago • 4 comments

Description

There're some places will print mismatch

  • authorizaer: it's testing mismatch cases
  • organization-service: testing PERMISSION_DENIED / NOT_FOUND (i.e. member update settings, stranger find org)

Important logic change:

  • organization-service: addOrUpdateMember with a new owner it will delete BUILT_IN one from org, add a runWithSubjectId to make sure it's the new owner going to delete the member.
  • workspace-starter: failInstanceStart it can happend no instance (at least in test case)

Others

  • bearer-authxxx.spec.ts: logic of expectError is not complete
  • Test cases to create orgniaztion via BUILT IN users, first joiner should be owner

Related Issue(s)

Fixed [internal chat]

How to test

Check changes of test cases (there're some note for changes on the Description section)

  • Run test in server
  • Should have no error like SubjectId mismatch except what described on PR Description section

Documentation

Preview status

gitpod:summary

Build Options

Build
  • [ ] /werft with-werft Run the build with werft instead of GHA
  • [ ] leeway-no-cache
  • [ ] /werft no-test Run Leeway with --dont-test
Publish
  • [ ] /werft publish-to-npm
  • [ ] /werft publish-to-jb-marketplace
Installer
  • [ ] analytics=segment
  • [ ] with-dedicated-emulation
  • [ ] workspace-feature-flags Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
  • [ ] /werft with-local-preview If enabled this will build install/preview
  • [ ] /werft with-preview
  • [ ] /werft with-large-vm
  • [x] /werft with-gce-vm If enabled this will create the environment on GCE infra
  • [x] /werft preemptible Saves cost. Untick this only if you're really sure you need a non-preemtible machine.
  • [ ] with-integration-tests=all Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh. If enabled, with-preview and with-large-vm will be enabled.
  • [ ] with-monitoring

/hold

mustard-mh avatar Mar 08 '24 10:03 mustard-mh

Sorry @mustard-mh , did manage to overlook this one. Will take a look this afternoon :bow:

geropl avatar Mar 19 '24 11:03 geropl

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Apr 22 '24 09:04 stale[bot]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar May 23 '24 15:05 github-actions[bot]

@mustard-mh Ugh, I did miss this PR again :sob:

I blocked some time early next week to look into that, incl. this PR. :date:

geropl avatar May 24 '24 09:05 geropl

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar Jun 04 '24 15:06 github-actions[bot]