gitpod icon indicating copy to clipboard operation
gitpod copied to clipboard

[server] decouple get ide config logic from server

Open iQQBot opened this issue 2 years ago • 2 comments

Description

Decouple get ide config logic from server

Related Issue(s)

Fixes #

How to test

  1. open preview environment, it should be able open a workspace
  2. go to setting -> preference, it should be able see all ide selection
  3. scaling down ide-service, the 1 and 2 step should work too (but with error output in server)
kubectl scale deployment ide-service --replicas 0
image
  1. scaling up ide-service, and check again (no error in server)
kubectl scale deployment ide-service --replicas 1

Release Notes

NONE

Documentation

Werft options:

  • [x] /werft with-preview
  • [ ] /werft with-integration-tests=all Valid options are all, workspace, webapp, ide

iQQBot avatar Sep 21 '22 09:09 iQQBot

started the job as gitpod-build-pd-ide-service.1 because the annotations in the pull request description changed (with .werft/ from main)

/hold until Tuesday

iQQBot avatar Sep 23 '22 07:09 iQQBot

if a component is rolled back by patching it's version, it's often the case that the config is not patched also - causing non-backwards compatible issues.

I deliberately merged all server-related changes into one commit, which means that if a rollback occurs, it goes straight back to the previous version, which still uses its own logic to read the ide-config, and server-ide-config is not removed in this version (I deliberately left it in)

iQQBot avatar Sep 26 '22 12:09 iQQBot

It's just generated in a different location in the installer, but the rendered result is the same

iQQBot avatar Sep 26 '22 12:09 iQQBot

/werft run

:+1: started the job as gitpod-build-pd-ide-service.19 (with .werft/ from main)

iQQBot avatar Sep 27 '22 13:09 iQQBot

/unhold

iQQBot avatar Sep 27 '22 14:09 iQQBot