gitpod icon indicating copy to clipboard operation
gitpod copied to clipboard
verified publisher icon gitpod-io

Usage-based pricing - validate that self-hosted Gitpod users are not impacted by UBP changes

Open jldec opened this issue 3 years ago • 2 comments

Feature flags should ensure that there is no impact of UBP on self-hosted Gitpod installations, but this needs to be validated.

  • no unexpected UBP-related errors during install or at run-time
  • no billing config or usage view for teams or individuals
  • no workspace or prebuild errors related to usage limits

jldec avatar Sep 14 '22 16:09 jldec

For ensuring exactly this we introduced the concept of BillingMode, with the possible values of none, chargebee and usage-based. And the relevant lines of code are here: if enablePayment is not set to true by the installer, the BillingMode for all users (and teams) defaults to none.

This BillingMode influences three things (which cover all ground mentioned above):

  • it governs what users can see on the dashboard (an improvement over the prior state!)
  • it governs what API users can use (e.g., being allowed to call upgradeSubscription or not)
  • it governs which implementation (strategy) of the EnttilementService is used to figure out what a user is entitled to do. Here's the implementation for none (should be named license, really. My fault :roll_eyes: ): EntitlementServiceLicense

That being said: we should still test, though. :upside_down_face:

geropl avatar Sep 15 '22 06:09 geropl

Request deleteTeam failed with message: Stripe is not properly configured

This error blocks from team deletion, if payment is not configured.

AlexTugarev avatar Sep 21 '22 10:09 AlexTugarev

@geropl what is the ask here towards the self-hosted team? If this is about spinning up self-hosted environments to test this, you should be able to use the environments during next week's release week to test this :)

lucasvaltl avatar Sep 23 '22 08:09 lucasvaltl

@lucasvaltl Absolutely! This was before "release week" was decided :wink:

geropl avatar Sep 23 '22 08:09 geropl

We should target adding the usage view with the next (October) release.

svenefftinge avatar Sep 26 '22 07:09 svenefftinge

Issue: "Usage View" is visible in self-hosted but shows broken content. (context: https://gitpod.slack.com/archives/C01KLC56NP7/p1664288507520209 )

geropl avatar Sep 27 '22 14:09 geropl

FYI - edited issue description to include 2 new issues as sub-tasks (fix usage view and team deletion)

jldec avatar Sep 28 '22 07:09 jldec

This item has been marked as completed in the 2022.09.0 release document (internal notion), I believe this issue is done.

adrienthebo avatar Sep 30 '22 17:09 adrienthebo