gitpod icon indicating copy to clipboard operation
gitpod copied to clipboard

Sync terraform EKS module with the reference architecture

Open nandajavarma opened this issue 2 years ago • 0 comments

Description

This PR adds a single-cluster AWS terraform module, corresponding to our reference architecture for the same cloud provider.

Related Issue(s)

Fixes #11533

How to test

You can follow the README added to this PR to test this terraform module.

Release Notes

NONE

Documentation

Werft options:

  • [ ] /werft with-preview

nandajavarma avatar Aug 09 '22 11:08 nandajavarma

@lucasvaltl I have addressed the comments. Sorry on the back and forth on this. I kinda of went easy on the configurable settings considering it can/will be changed. I will keep this in mind and try to do an exact 1:1 config.

nandajavarma avatar Aug 10 '22 18:08 nandajavarma

👍 Thank you! And no worries - maybe the intent here was not clear enough from my side. We want this terraform to effectively create exactly what the guide describes :)

lucasvaltl avatar Aug 10 '22 18:08 lucasvaltl

👋 It seems that errors can still creep up during the make plan phase on the EKS side: see screenshot here (internal). If I remember correctly, these were the exact same errors I ran into as well. On my side, it was because I was not starting off of a clean slate. I assume that @mbrevoort was although I am not sure. Can we please take a look at this before we merge this to see if we can get rid of these errors? Alternatively, if this is a case of users doing it wrong, it is likely worth updating the readme :)

lucasvaltl avatar Aug 17 '22 06:08 lucasvaltl

/unhold

nandajavarma avatar Aug 18 '22 19:08 nandajavarma