gitpod icon indicating copy to clipboard operation
gitpod copied to clipboard

[UBP] Add placeholder implementation of `FinalizeInvoice`

Open andrew-farries opened this issue 3 years ago • 1 comments

Description

Add a trivial 'noop' implementation of FinalizeInvoice to the billing RPC service.

Related Issue(s)

Part of #10937

How to test

  • Unit test for the billing service or
  • Port-forward to the usage service gRPC server:
kubectl port-forward svc/usage 9001:9001
  • Use evans or grpcurl to hit the placeholder FinalizeInvoice RPC with an invoice id of e.g: 1234
  • Tail the logs of deploy/usage and see:
{"level":"info","message":"Finalizing invoice for invoice \"1234\"","serviceContext":{"service":"usage","version":"commit-0aa8abfc2d3b27707a248d3ab285d3561202ceab"},"severity":"INFO","time":"2022-08-08T07:27:39Z"}

Release Notes

NONE

Documentation

Werft options:

  • [x] /werft with-preview
  • [x] /werft with-payment

andrew-farries avatar Aug 08 '22 07:08 andrew-farries

started the job as gitpod-build-af-placeholder-finalize-invoice-impl.4 because the annotations in the pull request description changed (with .werft/ from main)

Taking a look!

laushinka avatar Aug 10 '22 12:08 laushinka

This is so cool Screenshot 2022-08-10 at 14 43 26

laushinka avatar Aug 10 '22 12:08 laushinka