gitpod icon indicating copy to clipboard operation
gitpod copied to clipboard

Use prebuild workspace class for regular workspaces

Open Furisto opened this issue 2 years ago • 3 comments

Description

Ensure that if a prebuild is used to create a workspace a class is used that is appropriate for the workspace; meaning if the prebuild has a workspace class greater than the currently configured one by the customer the prebuild class is used, otherwise the class configured by the customer is used.

Related Issue(s)

Fixes #https://github.com/gitpod-io/gitpod/issues/11972 Needs https://github.com/gitpod-io/ops/pull/3728

How to test

  • Select workspace class g1-large
  • Start a prebuild
  • Select workspace class g1-standard
  • Create a regular workspace from prebuild
  • The workspace should have g1-large --
  • Start a prebuild for another repository (with g1-standard)
  • Select workspace class g1-large
  • Create a regular workspace from prebuild
  • The workspace should have g1-large

Release Notes

None

Documentation

Werft options:

  • [x] /werft with-preview

Furisto avatar Aug 05 '22 09:08 Furisto

started the job as gitpod-build-fo-prebuild-class.2 because the annotations in the pull request description changed (with .werft/ from main)

if the prebuild has a workspace class greater than the currently configured one by the customer the prebuild class is used

Apologies for the drive-by thought, but can't this have potentially unwanted consequences like:

  • one user prefers XL but has also set up Prebuilds for a project, thus "forcing" every project member to also use XL?
  • a team on a business plan using XL for an open source project, thus accidentally forcing every external contributor to also use XL?

Not blocking for this PR, but we'll probably need to figure out a good UX for these cases. 🤔

jankeromnes avatar Aug 08 '22 19:08 jankeromnes

@jankeromnes You are absolutely correct. This needs better UX, but we will enable this feature for only a very limited number of customers first, where it is understood that this is the current behavior. See https://gitpod.slack.com/archives/C02F19UUW6S/p1659639905273709 for some internal discussion about this.

Furisto avatar Aug 08 '22 19:08 Furisto

/werft run

:+1: started the job as gitpod-build-fo-prebuild-class.16 (with .werft/ from main)

laushinka avatar Aug 11 '22 09:08 laushinka