gitpod icon indicating copy to clipboard operation
gitpod copied to clipboard

[ws-manager] potential go routines leak

Open jenting opened this issue 2 years ago • 5 comments

Bug description

In us47, the ws-manager seems to have potential go routines leak, and it doesn't happen in eu47. 🤔 image

The symptom is that the ws-manager handles the gRPC request (such as creating workspace) pretty slowly. So, the user experience is they can't open the workspace.

As a workaround, we restart the ws-manager, after that, the go routines back to normal.

Steps to reproduce

No idea how to reproduce it so far. And here is the internal slack thread.

Workspace affected

No response

Expected behavior

No response

Example repository

No response

Anything else?

No response

jenting avatar Jun 30 '22 00:06 jenting

I've noticed in my Gitpod workspaces very recently (starting last week) that once I connect to my desktop VS code the memory from gp top increases 3-4gb and keeps climbing until crash, but it doesn't do this if i only use the web version of VS Code. Could it be related?

This happens to me using Gitpod SaaS and also on the June release of Gitpod Self-Hosted

NotNoah avatar Jul 02 '22 00:07 NotNoah

From the pprof I dumped, the Goroutine leaks seem to happen in http(*persistConn)readLoop and http(*persistConn)writeLoop.

jenting avatar Jul 04 '22 08:07 jenting

We still see the Goroutines increase in the us54 cluster. Reopen it.

image

jenting avatar Jul 26 '22 03:07 jenting

eu54 does not appear to have the issue:

image

here is us54: image

perhaps the issue is related to prebuilds, which generally occur in US region.

kylos101 avatar Aug 01 '22 01:08 kylos101

@jenting I am going to move this back to our inbox for now. Let's revisit soon, once there's bandwidth in Breakdown and Scheduled columns.

kylos101 avatar Aug 10 '22 02:08 kylos101

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Nov 09 '22 07:11 stale[bot]

This issue should be fixed by https://github.com/gitpod-io/gitpod/pull/14214

Close it.

jenting avatar Nov 09 '22 09:11 jenting

Closing as not planned and removing from project.

kylos101 avatar Nov 09 '22 22:11 kylos101