gitpod icon indicating copy to clipboard operation
gitpod copied to clipboard

feature(supervisor): installation of dotfiles via Makefile

Open ghuntley opened this issue 3 years ago • 6 comments

Description

I and many folks use a Makefile as a standard interface to dotfiles. This pull-request adds support for Makefiles

How to test

  • Change was directly applied using GitHub editor and is pending test
  • Start instance, configure dotfiles repo with Makefile - does it work?

Release Notes

feature: installation of dotfiles via Makefile

Documentation

Will require https://www.gitpod.io/docs/config-dotfiles to be updated once this ships.

ghuntley avatar Jun 22 '22 04:06 ghuntley

/werft run

:+1: started the job as gitpod-build-gh-dotfiles-makefile.1 (with .werft/ from main)

ghuntley avatar Jun 22 '22 04:06 ghuntley

/werft run

:+1: started the job as gitpod-build-gh-dotfiles-makefile.2 (with .werft/ from main)

ghuntley avatar Jul 01 '22 03:07 ghuntley

@csweichel @iQQBot does it make sense? Could you review please?

akosyakov avatar Jul 06 '22 07:07 akosyakov

Under normal circumstances, the makefile itself will not have execute permission, and instead of executing the makefile directly, we use the make command

iQQBot avatar Jul 06 '22 08:07 iQQBot

@ghuntley did you run some tests on this?

I think what @iQQBot is saying makes sense, you would not run Makefile instead you run the make cmd.

Is that what you do for your dotfiles?

Shall we convert the PR to draft for now? It doesn't seem to be ready to be merged 🤔

andreafalzetti avatar Jul 22 '22 05:07 andreafalzetti

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Aug 10 '22 03:08 stale[bot]