gitpod icon indicating copy to clipboard operation
gitpod copied to clipboard

Published 20 hours ago • verified publisher icon gitpod-io

refactor(dashboard/menu): persist team selection

Open aboqasem opened this issue 2 years ago • 6 comments

Description

Persist team selection for better UX.

Related Issue(s)

Fixes #10496

How to test

  1. Open dashboard
  2. Switch teams
  3. Click on Workspaces
  4. You should still be on your selected team
  5. Repeat 2 through 4 and optionally check local storage to see the team selection changing

Then:

  1. Visit root URL (/)
  2. The team selection should still be remembered

Release Notes

persist selected team across pages

Documentation

aboqasem avatar Jun 11 '22 06:06 aboqasem

  • [x] Creating a new team should change the persisted team to the new created team
  • [x] Visiting a team via URL should change the persisted team to the one in the URL
  • [x] Deleting a team should remove the persisted team

aboqasem avatar Jun 11 '22 06:06 aboqasem

Now even /projects does not depend on the URL to have /t/[slug]. That is a problem AFAIK, right?

I am used to Next.js routing not to react-router, my bad 😅!

aboqasem avatar Jun 11 '22 07:06 aboqasem

The current behavior I implemented is for pages to be aware of the team even if the URL does not contain the team slug. I do not know whether this is wanted 🙂

aboqasem avatar Jun 12 '22 02:06 aboqasem

/werft run

:+1: started the job as gitpod-build-improve-persist-team-selection-fork.0 (with .werft/ from main)

gtsiolis avatar Jun 14 '22 10:06 gtsiolis

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Jun 24 '22 11:06 stale[bot]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Jul 30 '22 17:07 stale[bot]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Sep 08 '22 22:09 stale[bot]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Sep 24 '22 05:09 stale[bot]

hey @aboqasem !Super sorry this PR slipped our attention. It's now quite outdated and I didn't see it when I started on #13316 . I'll bring this up with team so we can improve our handling of contributions.

svenefftinge avatar Sep 27 '22 06:09 svenefftinge