gitpod icon indicating copy to clipboard operation
gitpod copied to clipboard

Published 20 hours ago • verified publisher icon gitpod-io

refactor(dashboard/new-project): persist selected provider host

Open aboqasem opened this issue 3 years ago • 9 comments

Description

Persist the selected provider locally for better UX.

Related Issue(s)

Fixes #8524

How to test

  1. Open dashboard
  2. Navigate to projects
  3. Click "New Project"
  4. Change the selected provider
  5. Refresh
  6. Repeat 4 and 5 and optionally check local storage to see the host changing

Release Notes

persist selected provider when creating a new project

Documentation

N/A

aboqasem avatar Jun 09 '22 03:06 aboqasem

Thanks a lot for the contribution! ♥️ Flagging this for review.

jankeromnes avatar Jun 09 '22 17:06 jankeromnes

Glad to help! I have done the CLA now.

aboqasem avatar Jun 10 '22 01:06 aboqasem

Awesome, many thanks @aboqasem! 🎉

@meysholdt please confirm good reception of CLA. 🙏

jankeromnes avatar Jun 10 '22 08:06 jankeromnes

Ah, the CI doesn't pick up review comments, so let's try this again:

/werft run

:+1: started the job as gitpod-build-improve-persist-repo-provider-fork.0 (with .werft/ from main)

jankeromnes avatar Jun 10 '22 08:06 jankeromnes

Thank you for the review @jankeromnes!

aboqasem avatar Jun 10 '22 09:06 aboqasem

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Jun 22 '22 22:06 stale[bot]

hi @aboqasem, and thank you for your contribution. I checked but we don't have a signed CLA from you on file. Can you please sign our CLA via this DocuSign form? If there are any questions, you can reach me via [email protected].

meysholdt avatar Jul 26 '22 10:07 meysholdt

Thx for signing the CLA!

meysholdt avatar Jul 26 '22 13:07 meysholdt

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Aug 10 '22 03:08 stale[bot]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Sep 08 '22 22:09 stale[bot]

  • [x] /werft --with-preview

svenefftinge avatar Sep 12 '22 08:09 svenefftinge

/werft run

:+1: started the job as gitpod-build-improve-persist-repo-provider-fork.1 (with .werft/ from main)

svenefftinge avatar Sep 12 '22 08:09 svenefftinge

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Sep 24 '22 05:09 stale[bot]