gitpod icon indicating copy to clipboard operation
gitpod copied to clipboard

File Icon for `.gitpod.yml`

Open Siddhant-K-code opened this issue 3 years ago • 12 comments

Describe the behaviour you'd like

To have a Gitpod logo in .gitpod.yml file icon like all other products have (imgs below)

Screenshots

image image image

Describe alternatives you've considered

Alternative Suggested by @axonasif to use material-icon-theme, will look something like this:

Screenshot

image

Additional context

Extension API (in VS Code): https://code.visualstudio.com/api/extension-guides/file-icon-theme

Siddhant-K-code avatar Jun 06 '22 05:06 Siddhant-K-code

Can I pick this up?

asmitbm avatar Oct 08 '22 11:10 asmitbm

I checked the gitpod-vscode-desktop repo, and it already has an icon file in package,json. Is this issue fixed?

asmitbm avatar Oct 08 '22 12:10 asmitbm

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Jan 07 '23 18:01 stale[bot]

It uses Seti for default file icons. We would need to add the icon there. Also, Read this.

Resources:


Can I pick this up?

@Asmit2952 If you are still interested, you can send out the PR, Let me know, and I can assign you this.

Siddhant-K-code avatar Jan 08 '23 07:01 Siddhant-K-code

Hey, I have added and created a PR for Gitpod Icon in Seti. You can assign this issue to me.

ShashwatNautiyal avatar Jan 29 '23 18:01 ShashwatNautiyal

cc @gtsiolis @chrifro

akosyakov avatar Jan 29 '23 18:01 akosyakov

Thanks, @ShashwatNautiyal. I can assign this to you. I've left a comment (https://github.com/jesseweed/seti-ui/pull/673#pullrequestreview-1274286840) on the PR

Siddhant-K-code avatar Jan 29 '23 19:01 Siddhant-K-code

image

As per the seti-ui the icon must have a single color while the official SVG has a linear gradient and the size of the icon must be 18x18 with a 32x32 frame.

So I have tweaked the official icon size in the sketch and updated the SVG to match with seti-ui requirements.

ShashwatNautiyal avatar Jan 29 '23 20:01 ShashwatNautiyal

Cross-posting for visibility a comment I left in the relevant PR:

  • https://github.com/jesseweed/seti-ui/pull/673#pullrequestreview-1275048687

Cc @ShashwatNautiyal @Siddhant-K-code @chrifro @akosyakov

gtsiolis avatar Jan 30 '23 12:01 gtsiolis

I have updated the SVG and left a comment on the PR.

https://github.com/jesseweed/seti-ui/pull/673#issuecomment-1408600555

Cc @gtsiolis

ShashwatNautiyal avatar Jan 30 '23 13:01 ShashwatNautiyal

Is this issue still open! If is it then please assign it to me.

rajeevkumar504 avatar Mar 14 '23 02:03 rajeevkumar504

Is this issue still open! If is it then please assign it to me.

Thanks for your interest, @Rajeevjewar. Issue is still open, but it's implemented (https://github.com/jesseweed/seti-ui/pull/673) and the action item is due on seti's side 😄

Siddhant-K-code avatar Mar 14 '23 13:03 Siddhant-K-code