gitpod icon indicating copy to clipboard operation
gitpod copied to clipboard

[analytics] add error field to feedback event

Open laushinka opened this issue 3 years ago • 8 comments

Description

This adds the error message/object along with the feedback tracking event.

With error Without error
Screenshot 2022-06-03 at 14 18 12 Screenshot 2022-06-03 at 15 26 14

Related Issue(s)

Fixes #10402

How to test

  1. Trigger an error when creating a workspace (steps here).
  2. Visit Segment and filter for feedback_submitted.
  3. See the error_rendered body.
  4. Send a non-error feedback and see no error_rendered field on Segment.

Release Notes

NONE
  • [x] /werft with-preview
  • [x] /werft analytics=segment|TEZnsG4QbLSxLfHfNieLYGF4cDwyFWoe

laushinka avatar Jun 03 '22 11:06 laushinka

/werft run

:+1: started the job as gitpod-build-laushinka-send-error-message-with-10402.1 (with .werft/ from main)

laushinka avatar Jun 03 '22 11:06 laushinka

I think we should try to include the actual error text in the feedback report

Information about the context would be good too e.g. to tell the difference between 404 errors in say a. starting a workspace from a repo URL context vs. b. starting a workspace from a snapshot URL

jldec avatar Jun 07 '22 08:06 jldec

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Jun 18 '22 16:06 stale[bot]

started the job as gitpod-build-laushinka-send-error-message-with-10402.4 because the annotations in the pull request description changed (with .werft/ from main)

@laushinka I rebased and updated the werft flags in the description

jldec avatar Jul 15 '22 16:07 jldec

Testing error reporting on workspace start with private repo

Screenshot 2022-07-15 at 18 07 22 Screenshot 2022-07-15 at 18 08 26

jldec avatar Jul 15 '22 17:07 jldec

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Jul 30 '22 17:07 stale[bot]

This implementation works, but it is incomplete because the error message text is not included with the feedback. We either have to grab an image, or (better), extract the error message text as a string.

Currently, error handling implementations e.g. in CreateWorkspace.tsx render errors directly to HTML, instead of starting with plaintext first, and then rendering it.

jldec avatar Aug 10 '22 08:08 jldec

Closing because too stale. Picked up here.

laushinka avatar Sep 15 '22 10:09 laushinka