audio-webui icon indicating copy to clipboard operation
audio-webui copied to clipboard

[FEATURE REQUEST] RVC 2.0 48k Sample rate?

Open Ph0rk0z opened this issue 1 year ago • 12 comments

There are now 48k v2 models and a fork with a hybrid training feature. Are they any better?

https://github.com/Mangio621/Mangio-RVC-Fork

Files from YT are generally 48k. The only issue is the demucs models mainly do 44.1, although demucs can supposedly support 24bit. https://github.com/facebookresearch/demucs/issues/288

Am unsure how upsample vs downsample works out for final output.

Ph0rk0z avatar Jun 28 '23 12:06 Ph0rk0z

They might be better, i'll implement it. Not immediately though, i'm currently making an improved install system.

gitmylo avatar Jun 28 '23 12:06 gitmylo

No worries. For install I actually reused my nvida environment and added the handful of extra packages so I always bypass the venv entirely.

Ph0rk0z avatar Jun 28 '23 13:06 Ph0rk0z

I'd like to request adding the option of using the "mango-crepe" algorithm too for training and generating

nekogecko2 avatar Jun 30 '23 03:06 nekogecko2

While adding v2 48k i realized v1 48k doesn't work, i have some fixing to do

gitmylo avatar Jun 30 '23 11:06 gitmylo

Yea.. you're right. I had tried V1 48k and assumed something was wrong with my system instead.

Ph0rk0z avatar Jun 30 '23 12:06 Ph0rk0z

Yeah, once i fix that, v2 48k should also work

gitmylo avatar Jun 30 '23 12:06 gitmylo

I will try to re-run some datasets and see if the quality is higher. If only any demucs supported 48k. With already clean samples or self-recorded audio it will probably be a nice improvement.

Ph0rk0z avatar Jun 30 '23 12:06 Ph0rk0z

48k failed for me on training. I got the d/s converted. The 2nd wav folder doesn't generate files. The one where the # of items would be double. All the other ones happen but training goes down on tensor shape/size.

Ph0rk0z avatar Jul 07 '23 12:07 Ph0rk0z

48k failed for me on training. I got the d/s converted. The 2nd wav folder doesn't generate files. The one where the # of items would be double. All the other ones happen but training goes down on tensor shape/size.

That message above was one message not 2, it said once i fix that, v2 48k should also work, but i haven't worked on fixing it yet.

gitmylo avatar Jul 07 '23 15:07 gitmylo

Fair, I'm just saying how far I got testing it.

Ph0rk0z avatar Jul 08 '23 12:07 Ph0rk0z

48k failed for me on training. I got the d/s converted. The 2nd wav folder doesn't generate files. The one where the # of items would be double. All the other ones happen but training goes down on tensor shape/size.

That message above was one message not 2, it said once i fix that, v2 48k should also work, but i haven't worked on fixing it yet.

Hi Mylo!, is v2 48k working currently or shall we wait?

halilergul1 avatar Jul 24 '23 10:07 halilergul1

48k failed for me on training. I got the d/s converted. The 2nd wav folder doesn't generate files. The one where the # of items would be double. All the other ones happen but training goes down on tensor shape/size.

That message above was one message not 2, it said once i fix that, v2 48k should also work, but i haven't worked on fixing it yet.

Hi Mylo!, is v2 48k working currently or shall we wait?

Not yet, i haven't really been working on it, 48k works in inference by the way, just not during training.

gitmylo avatar Jul 24 '23 10:07 gitmylo