terraform-provider-gitlab icon indicating copy to clipboard operation
terraform-provider-gitlab copied to clipboard

Feature Request: gitlab_service_jenkins

Open SeameX opened this issue 2 years ago • 4 comments

Feature Description

Hello,

we use jenkins for some of our projects. It would be awesome if the jenkins integration can be configured via terraform. At the moment we use null resources & curl. Ressource gitlab_service_jenkins is needed :)

https://docs.gitlab.com/ee/api/integrations.html#jenkins-ci

Best regards

SeameX

Do you want to implement this?

  • [ ] I would like to implement this myself 👷

SeameX avatar Mar 30 '22 14:03 SeameX

@timofurrer I took a look at go-gitlab and it seems it needs a little bit of work to bring the integration inline with the underlying API. On a cursory check it still is using the service endpoint name vs the integrations endpoint name in the URL and the ssl verification attribute is missing. I think there might be more but we can mark this as needing upstream go-gitlab work.

Shocktrooper avatar Apr 01 '22 18:04 Shocktrooper

On a cursory check it still is using the service endpoint name vs the integrations endpoint name in the URL and the ssl verification attribute is missing. I think there might be more but we can mark this as needing upstream go-gitlab work.

on that note a few things: (1) the service endpoint still works and is redirected to the integration one. (2) what about the resource name, should we start naming them gitlab_intergration_XXX instead of service to adhere to the new naming from GitLab?

timofurrer avatar Apr 03 '22 07:04 timofurrer

Do we want to do a mass rename potentially as a separate issue and then note that in the release notes? Also should probably do the URL change in the upstream go-gitlab library but not required for this provider to work.

Shocktrooper avatar Apr 03 '22 08:04 Shocktrooper

I think a mass rename is something for the v4 of the provider. However, we could alias existing ones and correctly name new ones. Where as the former is not really necessary IMHO, just name the new ones correctly for now :)

timofurrer avatar Apr 03 '22 09:04 timofurrer