terraform-provider-gitlab icon indicating copy to clipboard operation
terraform-provider-gitlab copied to clipboard

resource/gitlab_label: Add priority attribute

Open timofurrer opened this issue 2 years ago • 8 comments

Closes: #69

Blocked by:

  • https://github.com/xanzy/go-gitlab/pull/1407

The PR above highlights the issue why this is blocked: basically go-gitlab doesn't support nullable fields in responses, which would be required for the priority field.

timofurrer avatar Mar 07 '22 10:03 timofurrer

This pull request has merge conflicts. Please rebase your branch onto main.

github-actions[bot] avatar Mar 19 '22 11:03 github-actions[bot]

Marking this pull request as stale due to 30 days of inactivity. If this pull request receives no comments in the next 14 days it will be closed. Maintainers can also remove the stale label.

To help this pull request get reviewed, please check that it is rebased onto the latest and is passing automated checks. It also helps if you could reference an issue that the pull request resolves, and create one if it doesn't exist.

github-actions[bot] avatar May 12 '22 03:05 github-actions[bot]

@timofurrer - I checked out the graphql API for labels to see if that helped out with this issue... there seems to be an API to create labels, and there is an API to read labels for projects along with an API to read labels for groups however there appears to be no mutation for actually updating a label. So no love here for helping with this issue :-/

PatrickRice-KSC avatar May 29 '22 00:05 PatrickRice-KSC

Marking this pull request as stale due to 30 days of inactivity. If this pull request receives no comments in the next 14 days it will be closed. Maintainers can also remove the stale label.

To help this pull request get reviewed, please check that it is rebased onto the latest and is passing automated checks. It also helps if you could reference an issue that the pull request resolves, and create one if it doesn't exist.

github-actions[bot] avatar Jun 28 '22 03:06 github-actions[bot]

Hey @timofurrer - I wonder if we could apply the same workaround for go-gitlab here that we did over here: https://github.com/gitlabhq/terraform-provider-gitlab/pull/971#discussion_r835801777

PatrickRice-KSC avatar Jun 29 '22 23:06 PatrickRice-KSC

Hey @timofurrer - I wonder if we could apply the same workaround for go-gitlab here that we did over here: #971 (comment)

@PatrickRice-KSC hmmm, where would you see the point to hook into the go-gitlab response handling? I guess what we could do is just query the API ourselves with a custom response struct ...

timofurrer avatar Jun 30 '22 07:06 timofurrer

@timofurrer - Oh shoot, my bad. It's in the response, not the request. I misread the note. Seems like we'd have to make a custom call at this point...

PatrickRice-KSC avatar Jul 01 '22 01:07 PatrickRice-KSC

Marking this pull request as stale due to 30 days of inactivity. If this pull request receives no comments in the next 14 days it will be closed. Maintainers can also remove the stale label.

To help this pull request get reviewed, please check that it is rebased onto the latest and is passing automated checks. It also helps if you could reference an issue that the pull request resolves, and create one if it doesn't exist.

github-actions[bot] avatar Jul 31 '22 04:07 github-actions[bot]

Marking this pull request as stale due to 30 days of inactivity. If this pull request receives no comments in the next 14 days it will be closed. Maintainers can also remove the stale label.

To help this pull request get reviewed, please check that it is rebased onto the latest and is passing automated checks. It also helps if you could reference an issue that the pull request resolves, and create one if it doesn't exist.

github-actions[bot] avatar Sep 01 '22 03:09 github-actions[bot]

This PR was closed because it has been stale for 14 days with no activity.

github-actions[bot] avatar Sep 15 '22 04:09 github-actions[bot]