terraform-provider-gitlab icon indicating copy to clipboard operation
terraform-provider-gitlab copied to clipboard

[Feature Request] Add Gitlab group webhook management

Open williamsbdev opened this issue 2 years ago • 7 comments

Affected Resource(s)

  • gitlab_group_hook

The provider currently supports gitlab_project_hook and other gitlab_group_* resources but there is no support yet for hooks at the group level.

https://docs.gitlab.com/ee/api/groups.html#add-group-hook

We'd like to request this resource in the Terraform provider so that we can manage our group webhooks with Terraform.

On another note, is there a roadmap of the features being worked/developed for this provider?

williamsbdev avatar Jul 29 '21 13:07 williamsbdev

@timofurrer I'm going to take a look at implementing this. I'll do an upstream alignment on fields in go-gitlab first. It looks like there may need to be some modifications to GitLab's API exposure as well to reach parity with the UI options, but I think that can come later.

jtymes avatar Mar 23 '22 01:03 jtymes

go-gitlab API alignment

  • https://github.com/xanzy/go-gitlab/pull/1427

jtymes avatar Mar 23 '22 01:03 jtymes

@jtymes sounds great!

It looks like there may need to be some modifications to GitLab's API exposure as well to reach parity with the UI options, but I think that can come later.

Can you elaborate on that? Maybe I can quickly add what's missing ...

timofurrer avatar Mar 23 '22 07:03 timofurrer

The UI has "Feature flag events", and "Member events" but the API does not. image image

hook.rb group_hook.rb triggerable_hooks.rb

Also, the API is returning what appears to be a system-level hook repository_update_events that cannot be changed from the group hook endpoint. Not sure if it should even be exposed in that endpoint.

jtymes avatar Mar 23 '22 10:03 jtymes

@williamsbdev Can I work on this ?

teekhandekar avatar Mar 26 '22 05:03 teekhandekar

Correct me if I'm wrong, but I think @jtymes already start working on this :)

timofurrer avatar Mar 26 '22 07:03 timofurrer

Yep, I'm already working on it. Just waiting on the upstream PR in go-gitlab.

jtymes avatar Mar 26 '22 12:03 jtymes

220 seat, Ultimate customer requesting this feature: https://gitlab.my.salesforce.com/0016100001aJso6

Customer's integration with Sumo Logic requires adding a webhook for each GitLab group.

/cc @nagyv

bgadberry-gitlab avatar Aug 17 '22 19:08 bgadberry-gitlab

@bgadberry-gitlab @nagyv I'll take care of this and if all goes well it'll be available in the next provider release shortly after 15.3 has been released ;)

timofurrer avatar Aug 17 '22 19:08 timofurrer

This functionality has been released in v3.17.0 of the Terraform GitLab Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue. Thank you!

github-actions[bot] avatar Aug 24 '22 18:08 github-actions[bot]