grit icon indicating copy to clipboard operation
grit copied to clipboard

Not able to support all of the git object

Open catatsuy opened this issue 11 years ago • 0 comments

The commit id d9bb4be · git/git warn "unknown header ''" when I use this gem on git/git.

It is the unexpected implementation of Grit::GitRuby::Commit::from_raw in grit/lib/grit/git-ruby/git_object.rb .

require "grit"

GIT_REPO = '../git'

repo_grit   = Grit::Repo.new(GIT_REPO)
repo_grit.commit('d9bb4be53bc5185244b4be986')

output:

header '' in commit d9bb4be53bc5185244b4be9860562a012803bacb
unknown header '' in commit d9bb4be53bc5185244b4be9860562a012803bacb
unknown header '' in commit d9bb4be53bc5185244b4be9860562a012803bacb
unknown header '' in commit d9bb4be53bc5185244b4be9860562a012803bacb
unknown header '' in commit d9bb4be53bc5185244b4be9860562a012803bacb
unknown header '' in commit d9bb4be53bc5185244b4be9860562a012803bacb
unknown header '' in commit d9bb4be53bc5185244b4be9860562a012803bacb
unknown header '' in commit d9bb4be53bc5185244b4be9860562a012803bacb
unknown header '' in commit d9bb4be53bc5185244b4be9860562a012803bacb
unknown header '' in commit d9bb4be53bc5185244b4be9860562a012803bacb
unknown header '' in commit d9bb4be53bc5185244b4be9860562a012803bacb
unknown header '' in commit d9bb4be53bc5185244b4be9860562a012803bacb
unknown header '' in commit d9bb4be53bc5185244b4be9860562a012803bacb
unknown header '' in commit d9bb4be53bc5185244b4be9860562a012803bacb
unknown header '' in commit d9bb4be53bc5185244b4be9860562a012803bacb

dump all_headers

[["tree", "399705cdf254f291b50418c2b1fd46586edcb145"],
 ["parent", "79fcbf7e703ca5805ebd46b2c7e09d0703f1c1ff"],
 ["parent", "1b2c79e63e5afa3cecb3ab4a40cb414dbe6511ce"],
 ["author", "Junio C Hamano <[email protected]> 1390338977 -0800"],
 ["committer", "Junio C Hamano <[email protected]> 1390338977 -0800"],
 ["mergetag", "object 1b2c79e63e5afa3cecb3ab4a40cb414dbe6511ce"],
 ["", "type commit"],
 ["", "tag gitgui-0.19.0"],
 ["", "tagger Pat Thoyts <[email protected]> 1390066238 +0000"],
 ["", ""],
 ["", "git-gui 0.19.0"],
 ["", "-----BEGIN PGP SIGNATURE-----"],
 ["", "Version: GnuPG v1.4.14 (GNU/Linux)"],
 ["", ""],
 ["", "iQCVAwUAUtq6P2B90JXwhOSJAQK3zQP/T+cOevbKCwFl9mif3EtgPgCoFS9Yd/93"],
 ["", "FYgoKxZh3t9i0Smo9EUggyEkx22v7vONwglGP1wCmCmniQRoaoTW4WBxJFJlEegt"],
 ["", "Li/7OilkwTrSgu1RFZTtpW7zYpg08YrkehFTo6Ntye5gyxZeHsmgFv56f6Ef9Egj"],
 ["", "qEf8xXLyjX4="],
 ["", "=IBoS"],
 ["", "-----END PGP SIGNATURE-----"]]

catatsuy avatar Jan 28 '14 13:01 catatsuy