Do not add entities that are marked as delete
Hi!
Current version of gitlabform tries to add entities (e.g. variables) that are present only in config, even if they are marked as delete.
This means, that on first run, gitlabform will delete entity "foo" and on the next run it will try to add it again.
This should fix this issue.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 82.74%. Comparing base (
70c008f) to head (2f91268). Report is 2 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@
## main #669 +/- ##
==========================================
+ Coverage 82.54% 82.74% +0.20%
==========================================
Files 74 74
Lines 2904 2904
==========================================
+ Hits 2397 2403 +6
+ Misses 507 501 -6
| Files | Coverage Ξ | |
|---|---|---|
| ...tlabform/processors/multiple_entities_processor.py | 96.20% <100.00%> (ΓΈ) |
Hi. Thanks for this PR. Is there an existing open issue for it? Could you please reference it or create a new issue? I didn't completely follow the problem you mentioned. Also it seems the acceptance tests are failing.
Hi @KrystianOcado - Did you get a chance to look into what I mentioned previously βοΈ ?
Hi @amimas !
Sorry about the delay, I've added an issue here: https://github.com/gitlabform/gitlabform/issues/684
Please let me know if you need more info.
Hey @KrystianOcado! We would love to get your contribution merged, but the tests need to pass first. Can you find the time to revisit this PR and fix them please?