gitlabform icon indicating copy to clipboard operation
gitlabform copied to clipboard

Do not add entities that are marked as delete

Open KrystianOcado opened this issue 2 years ago β€’ 5 comments

Hi!

Current version of gitlabform tries to add entities (e.g. variables) that are present only in config, even if they are marked as delete.

This means, that on first run, gitlabform will delete entity "foo" and on the next run it will try to add it again.

This should fix this issue.

KrystianOcado avatar Jan 17 '24 12:01 KrystianOcado

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 82.74%. Comparing base (70c008f) to head (2f91268). Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #669      +/-   ##
==========================================
+ Coverage   82.54%   82.74%   +0.20%     
==========================================
  Files          74       74              
  Lines        2904     2904              
==========================================
+ Hits         2397     2403       +6     
+ Misses        507      501       -6     
Files Coverage Ξ”
...tlabform/processors/multiple_entities_processor.py 96.20% <100.00%> (ΓΈ)

... and 4 files with indirect coverage changes

codecov[bot] avatar Jan 17 '24 12:01 codecov[bot]

Hi. Thanks for this PR. Is there an existing open issue for it? Could you please reference it or create a new issue? I didn't completely follow the problem you mentioned. Also it seems the acceptance tests are failing.

amimas avatar Jan 17 '24 19:01 amimas

Hi @KrystianOcado - Did you get a chance to look into what I mentioned previously ☝️ ?

amimas avatar Feb 10 '24 21:02 amimas

Hi @amimas !

Sorry about the delay, I've added an issue here: https://github.com/gitlabform/gitlabform/issues/684

Please let me know if you need more info.

KrystianOcado avatar Feb 15 '24 15:02 KrystianOcado

Hey @KrystianOcado! We would love to get your contribution merged, but the tests need to pass first. Can you find the time to revisit this PR and fix them please?

gdubicki avatar May 05 '24 12:05 gdubicki