vscode-gitlens
vscode-gitlens copied to clipboard
Uninstalls duplicate MCP
Description
Fixes #4626
Checklist
- [x] I have followed the guidelines in the Contributing document
- [x] My changes follow the coding style of this project
- [x] My changes build without any errors or warnings
- [x] My changes have been formatted and linted
- [x] My changes include any required corresponding changes to the documentation (including CHANGELOG.md and README.md)
- [x] My changes have been rebased and squashed to the minimal number (typically 1) of relevant commits
- [x] My changes have a descriptive commit message with a short title, including a
Fixes $XXX -orCloses #XXX -prefix to auto-close the issue that your PR addresses
@eamodio I have one doubt here.
I suppose, the result of the fix should give us the following:
- User comes to us and says "I have duplication of MCP"
- We say: "Try one of the following" (both work):
- Reload your IDE window
- Call
GitLens: Reinstall GitKraken MCPin the command palette.
However, now we might have problem with the option #2.
That's because, I call deduping after the successful config call, here:
But it's never called twice until the version of the GK CLI is updated:
Therefore, the question is the following:
- Is it OK that the second recipe won't always work (only once per launch)
- Or is it better to move deduping command to another place? e.g. from
onRegistrationCompletedtogetMcpConfigurationFromCLI?
cc @axosoft-ramint