vscode-gitlens
vscode-gitlens copied to clipboard
Bad credential of one integration ruins other integrations on Launchpad
Description
1. Silence of the Launchpad
Steps to reproduce
on GitLens v17.3.0
- Connect GitHub and GitLab on GKDev
- Sync integrations in GitLens
- Go to GitLab OAuth settings (or Azure) and reject the application (keep it connected on GKDev)
- for GitLab it stops working immediately, for Azure wait for 30min until the azure token expires
- Open the launchpad
Expected result
You see GitHub PRs
Actual result
You fail seeing any PRs, because of GitLab error:
Related issues:
- https://github.com/gitkraken/vscode-gitlens/issues/4731
Technical details
It feels like it's here: https://github.com/gitkraken/vscode-gitlens/blob/6dfa54175c2aa9488ec7ccba0254544edd9aed01/src/plus/integrations/integrationService.ts#L716-L756
Maybe we should not fail the whole procedure if one of integrations fails?
2. swallowing of an Authentication Error
...
GitLens Version
17.3.0
VS Code Version
No response
Git Version
No response
Logs, Screenshots, Screen Captures, etc
No response