vscode-gitlens icon indicating copy to clipboard operation
vscode-gitlens copied to clipboard

git tag messages are not properly shell escaped

Open SaculRennorb opened this issue 2 years ago • 1 comments

Description

Using Codium under Windows10 and using powershell as the shell, the message parameter for git tag does not seem to be properly escaped.

I do not know if there are other commands with the same problem, but since i use the addon quite a bit and it did not happen to me before it doesn't seem like there many more cases.

I also cannot tell if the issue is new or has been there fore a while, as i cannot remember if I ever tagged something with special characters before.

Also while I'm at it; is there a way to push tags to the remote via the gitlense UI? While I don't really mind, it does feel a bit strange to have to do that specific part via the command line but have context menus for everything else.

GitLens Version

v14.2.1

VS Code Version

Version: 1.81.1 Release: 23222 Commit: aef377c42cea6e9aea642829953104f07097abfa Date: 2023-08-10T18:29:45.715Z Electron: 22.3.18 ElectronBuildId: undefined Chromium: 108.0.5359.215 Node.js: 16.17.1 V8: 10.8.168.25-electron.0 OS: Windows_NT x64 10.0.19042

Git Version

git version 2.34.1.windows.1

Logs, Screenshots, Screen Captures, etc

Terminal output:

PS C:\Users\some\path> & "c:/Program Files/Git/cmd/git.exe" -C "c:/Users/some/path" -c "core.editor=codium --wait --reuse-window" tag -m ""SotO combat changes (Relics)"" v2.2.0 master
Relics : The term 'Relics' is not recognized as the name of a cmdlet, function, script file, or operable program. Check the spelling of the name, or if a path was included, verify that the path is correct and try again.       
At line:1 char:162
+ ... m --wait --reuse-window" tag -m ""SotO combat changes (Relics)"" v2.2 ...
+                                                            ~~~~~~
    + CategoryInfo          : ObjectNotFound: (Relics:String) [], CommandNotFoundException
    + FullyQualifiedErrorId : CommandNotFoundException

SaculRennorb avatar Aug 28 '23 05:08 SaculRennorb