vscode-gitlens icon indicating copy to clipboard operation
vscode-gitlens copied to clipboard

Published 20 hours ago • verified publisher icon gitkraken

Improve git blame contrast

Open mejiaj opened this issue 3 years ago • 2 comments

Git blame can be unreadable in some themes.

See Better Solarized Light theme

image

Monokai Pro Filtered image

Possible solutions

  • Default to a minimum contrast ratio for text
  • Give users options to set minimum contrast ratio (kind of like integrated terminal settings in VS Code) image

mejiaj avatar Jun 28 '22 14:06 mejiaj

@mejiaj thanks for bringing this up and something we'll certainly look to improve! We try to stay as cohesive as possible with a user's selected theme and incorporate as much of the theme's colors into Gitlens as we can. One of the challenges with that is not all themes are WCAG compliant.

d13 avatar Jun 28 '22 15:06 d13

@d13 totally understandable and I appreciate the response!

I know VS code allows you to override on a per-theme basis too. But like you mentioned a lot of the themes have their own contrast issues. As a person that likes to switch themes regularly, the overrides stack up.

mejiaj avatar Jun 28 '22 16:06 mejiaj