vscode-gitlens icon indicating copy to clipboard operation
vscode-gitlens copied to clipboard

Published 20 hours ago • verified publisher icon gitkraken

Fixes #1845, #1210 supports GitHub Enterprise Authentication Provider

Open forestaa opened this issue 2 years ago • 8 comments

Description

Gitlens supports GitHub Enterprise integration, but some features are not supported because github.com authentication workflow is triggered when connecting to GitHub Enterprise. This PR supports Github Enterprise authentication using https://github.com/microsoft/vscode/pull/115940. This enables us to provide automatic issue linking for GitHub Enterprise in details hover.

Thanks for the awesome extension! Any comments are welcome.

Fixes #1845, #1210

Checklist

  • [x] I have followed the guidelines in the Contributing document
  • [x] My changes follow the coding style of this project
  • [x] My changes build without any errors or warnings
  • [x] My changes have been formatted and linted
  • [x] My changes include any required corresponding changes to the documentation
  • [x] My changes have been rebased and squashed to the minimal number (typically 1) of relevant commits
  • [x] My changes have a descriptive commit message with a short title, including a Fixes $XXX - or Closes #XXX - prefix to auto-close the issue that your PR addresses

forestaa avatar Jun 04 '22 16:06 forestaa

@forestaa Awesome change. It will great to use gitlens with enterprise repos

wKich avatar Jun 29 '22 06:06 wKich

Trinh approved this PR! 🎉 hopefully, by Monday, we'll be able to use it at work 🙏

gianpaj avatar Jul 09 '22 11:07 gianpaj

Finally, gitlens add github enterprise support for paid gitlens+ users. https://github.com/gitkraken/vscode-gitlens/commit/34bab7b3874ac598ece9e0b3930a0bb021b4e2a8

forestaa avatar Jul 13 '22 12:07 forestaa

Hmm, so this was an open source contribution, but they made it a paid feature?

chen-ye avatar Jul 13 '22 16:07 chen-ye

Seriously...why is this a paid feature?

kavehv avatar Jul 27 '22 20:07 kavehv

Trinh approved this PR! 🎉 hopefully, by Monday, we'll be able to use it at work 🙏

lol, you can approve also, @gianpaj

trinhpham avatar Jul 29 '22 03:07 trinhpham

Is this a paid feature or just hasn't been released yet? Hopefully released in 12.1.3?

rockboynton avatar Aug 04 '22 21:08 rockboynton

https://github.com/gitkraken/vscode-gitlens/issues/1210 This will be a paid feature and will be release in 12.2 since the above issue is labelled as milestone 12.2.

forestaa avatar Aug 05 '22 04:08 forestaa

I'm closing the PR because v12.2.0 is released and the rich integration with Github Enterprise is supported. https://github.com/gitkraken/vscode-gitlens/releases/tag/v12.2.0

forestaa avatar Sep 21 '22 23:09 forestaa