vscode-gitlens icon indicating copy to clipboard operation
vscode-gitlens copied to clipboard

Closes #1606 - Change "Url" text to "URL"

Open pguilbert opened this issue 3 years ago • 3 comments


#1606

Description

Change all occurrence of the capitallized "Url" to "URL" to match with the Visual Studio Code Language Packs.

Checklist

  • [x] I have followed the guidelines in the Contributing document
  • [x] My changes follow the coding style of this project
  • [x] My changes build without any errors or warnings
  • [x] My changes have been formatted and linted
  • [ ] My changes include any required corresponding changes to the documentation
  • [x] My changes have been rebased and squashed to the minimal number (typically 1) of relevant commits
  • [x] My changes have a descriptive commit message with a short title, including a Fixes $XXX - or Closes #XXX - prefix to auto-close the issue that your PR addresses

pguilbert avatar Jan 16 '22 12:01 pguilbert

... I don't know how I missed the previous PR #1607.

Is this issue still relevant ?

pguilbert avatar Jan 16 '22 12:01 pguilbert

I agree that the issue is still relevant. URL is an acronym and should be capitalised. The current capitalisation was noticeable to me and led me to find this pull request and its related issue.

Under certain symbol naming conventions it is not unusual to see only the first letter of the acronym capitalised on occasion to improve readability (e.g. repositoryUrlLength), but in a user interface this is not correct.

The Oxford English Dictionary, Cambridge Dictionary and Merriam-Webster Dictionary all define URL as a fully capitalised acronym and use it as such in their examples.

JamieEdge avatar Feb 17 '22 20:02 JamieEdge

Thank you for your comment @JamieEdge and your contribution @pguilbert, I believe this issue is still relevant. It's unfortunate that https://github.com/gitkraken/vscode-gitlens/pull/1607 was closed.

Interestingly, the text of the latest commit has URL capitalized correctly: "Updates to absolute URL" (a32b187d5d0bcd34c88dfa003d4cdb4cf8fc3d28).

dnicolson avatar Jun 14 '22 21:06 dnicolson

Thanks! I've come around and am open to merging this once the conflicts are resolved and the other missing instances are included.

eamodio avatar Nov 03 '22 04:11 eamodio

@pguilbert are you able take a look at this?

dnicolson avatar Nov 06 '22 18:11 dnicolson

@eamodio please have a look at https://github.com/gitkraken/vscode-gitlens/pull/2341.

dnicolson avatar Nov 11 '22 18:11 dnicolson