vscode-gitlens icon indicating copy to clipboard operation
vscode-gitlens copied to clipboard

Adds custom avatar

Open tmkx opened this issue 4 years ago • 11 comments

Description

Allow custom avatar url rule, backward compatible.

 "gitlens.remotes": [
   {
     "domain": "gitlab.intranet.com",
     "type": "Custom",
     "name": "Company",
     "protocol": "https",
     "urls": {
       "repository": "https://gitlab.intranet.com/${repo}",
       "branches": "https://gitlab.intranet.com/${repo}/branches",
       "branch": "https://gitlab.intranet.com/${repo}/commits/${branch}",
       "commit": "https://gitlab.intranet.com/${repo}/commit/${id}",
       "file": "https://gitlab.intranet.com/${repo}?path=${file}${line}",
       "fileInBranch": "https://gitlab.intranet.com/${repo}/blob/${branch}/${file}${line}",
       "fileInCommit": "https://gitlab.intranet.com/${repo}/blob/${id}/${file}${line}",
       "fileLine": "#L${line}",
       "fileRange": "#L${start}-L${end}",
+      "avatar": "https://avatar.intranet.com/employee?username=${name}&size=${size}"
     }
   }
 ]

close #302 close #1036

Checklist

  • [x] I have followed the guidelines in the Contributing document
  • [x] My changes follow the coding style of this project
  • [x] My changes build without any errors or warnings
  • [x] My changes have been formatted and linted
  • [x] My changes include any required corresponding changes to the documentation
  • [x] My changes have been rebased and squashed to the minimal number (typically 1) of relevant commits
  • [x] My changes have a descriptive commit message with a short title, including a Fixes $XXX - or Closes #XXX - prefix to auto-close the issue that your PR addresses

tmkx avatar Sep 13 '21 02:09 tmkx

seems very promising. The MR will also give a more general solution to #281.

However the way custom avatar uri was provided was as a member of the Account class, bond to a commit. Might need further review from the repo maintainer.

xiaoas avatar Dec 27 '21 11:12 xiaoas

@tmkx , Why this PR is still pending? My organization is using azure devops, does this PR work on azure devops?

manc-lx avatar Aug 10 '22 08:08 manc-lx

@tmkx , Why this PR is still pending? My organization is using azure devops, does this PR work on azure devops?

It's fully customizable, as well as can be used in azure.

tmkx avatar Aug 10 '22 10:08 tmkx

Is anyone still actively working on this?

nunnsy avatar Oct 19 '22 16:10 nunnsy

thanks @tmkx! @axosoft-ramint @eamodio just wondering if there's anything that needs to be done here before a review? cheers

nunnsy avatar Nov 09 '22 15:11 nunnsy

Is there any movement on this? I found issue https://github.com/gitkraken/vscode-gitlens/issues/281 which is marked as closed but it seems to not function/there is no setting(?). I can't reply on the issue as it's marked as closed with no comments.

This PR seems like a fix for it and it's been sitting for a while.

Echoing what @nunnsy said; @tmkx is this ready for review?

John-Dean avatar Jan 18 '23 23:01 John-Dean

@tmkx is this ready for review?

Yes

tmkx avatar Jan 19 '23 00:01 tmkx

When the PR will be merged into the main branch? @eamodio @d13

baranwang avatar Mar 21 '23 02:03 baranwang

When the PR will be merged into the main branch?

latel avatar Jul 12 '23 05:07 latel

ping @eamodio @d13 @axosoft-ramint

baranwang avatar Oct 19 '23 03:10 baranwang