vscode-gitlens icon indicating copy to clipboard operation
vscode-gitlens copied to clipboard

Fixes #1328 - Adds support for reading file history for files which o…

Open sweiss3 opened this issue 4 years ago • 4 comments

Description

Fixes #1328 - Adds support for reading the file history for files which originate from symlinks

Checklist

  • [x] I have followed the guidelines in the Contributing document
  • [x] My changes follow the coding style of this project
  • [x] My changes build without any errors or warnings
  • [x] My changes have been formatted and linted
  • [x] My changes include any required corresponding changes to the documentation
  • [x] My changes have been rebased and squashed to the minimal number (typically 1) of relevant commits
  • [x] My changes have a descriptive commit message with a short title, including a Fixes $XXX - or Closes #XXX - prefix to auto-close the issue that your PR addresses

sweiss3 avatar Jan 17 '21 11:01 sweiss3

To test, you can use the following repo:

https://github.com/sweiss3/SampleRepo1.git

Detailed steps:

git clone https://github.com/sweiss3/SampleRepo1.git
cd SampleRepo1
git submodule update --init --recursive
.\create_link.cmd

And open VSCode on SampleRepo1.

You will see that if you navigate to the text file inside LinkToSampleRepo2, GitLens will show an error in the console. With the PR applied, it should show the proper history.

sweiss3 avatar Jan 25 '21 21:01 sweiss3

@eamodio Any comments/feedback on this?

sweiss3 avatar Feb 22 '21 10:02 sweiss3

@aekewu @glaukiol1 Thank you for your review. Should I do anything to actively merge this? I'm not so proficient with GitHub just yet.

sweiss3 avatar May 09 '21 06:05 sweiss3

@eamodio Can this PR be merged? Is there any issue with it?

sweiss3 avatar Aug 24 '21 06:08 sweiss3

@glaukiol1 Can you please advise on how to get this PR merged?

sweiss3 avatar Feb 20 '23 07:02 sweiss3