gitify icon indicating copy to clipboard operation
gitify copied to clipboard

Remove @electron/remote

Open bmulholland opened this issue 2 years ago • 3 comments

Usage of @electron/remote is discouraged

We can replace it with inter-process communication fairly easily, just need to do it piece by piece.

bmulholland avatar Oct 03 '23 11:10 bmulholland

@bmulholland - would you mind confirming that this can be closed. I did a search and couldn't find any references to remote from the electron package directly. All seem to have been migrated to @electron/remote (thank you kindly)

setchy avatar Apr 03 '24 03:04 setchy

All seem to have been migrated to @electron/remote

That's the package that is discouraged and shouldn't be used. From the linked article, about @electron/remote itself:

⚠️ Warning! This module has many subtle pitfalls. There is almost always a better way to accomplish your task than using this module. For example, ipcRenderer.invoke can serve many common use cases.

bmulholland avatar Apr 03 '24 11:04 bmulholland

Oops! I misread it. I focused on this comment but missed the warning. Thanks for the correction 🙇

@electron/remote is a replacement for the built-in remote module in Electron, which is deprecated and will eventually be removed.

setchy avatar Apr 03 '24 15:04 setchy

@electron/remote no longer used https://github.com/gitify-app/gitify/pull/1781

setchy avatar Jan 29 '25 16:01 setchy