gitify icon indicating copy to clipboard operation
gitify copied to clipboard

Fix Github Enterprise Login (Deduplicate api-url generate code)

Open uanid opened this issue 4 years ago • 1 comments

Hello,

I saw #524, Also I tested with latest commits. But Login to Github Enterprise Server with PAT not works. (See #527) Because Github Etnerprise Server's API url pattern is https://${hostname}/api/v3.

Changes

This PR deduplicates api-url generate codes.

Github Enterprise API url reference

https://docs.github.com/en/[email protected]/rest/reference/users image

uanid avatar Dec 23 '21 17:12 uanid

Thank you @Uanid for fixing this and @codebytere for reviewing this 🙂 . Do we know whose approval from maintainers do we need here ?

pbsureja avatar Jan 19 '22 19:01 pbsureja

@pbsureja want to make the same PR in my fork? 🙂 https://github.com/Araxeus/gitify

Araxeus avatar Feb 04 '23 07:02 Araxeus