gitify icon indicating copy to clipboard operation
gitify copied to clipboard

Mark as read when clicking notification

Open aparajita opened this issue 4 years ago • 6 comments

Gitify 3.0.5 macOS 10.15.5

When clicking a notification, it correctly takes me to the relevant place in github, but the corresponding item in Gitify is not marked as read.

aparajita avatar Jun 02 '20 15:06 aparajita

I've just upgraded and it appears to work fine for me. Does the notification still appear after you hit the refresh icon?

JakeSidSmith avatar Jun 03 '20 08:06 JakeSidSmith

The point is I shouldn't have to manually refresh. 😁

aparajita avatar Jun 03 '20 13:06 aparajita

hmm - i'm on the same version and i've not had to manually refresh 🤔 do you have a gif or something demonstrating the behavior?

codebytere avatar Jun 19 '20 16:06 codebytere

Leave a comment again so I can record.

aparajita avatar Jun 19 '20 16:06 aparajita

The point is I shouldn't have to manually refresh. 😁

The reason I asked was to make sure that they are actually marked as read, which they are, there is not a bug.

Gitify polls the notifications every 60 seconds. So they will disappear from the app within a minute at most.

Is what you are asking for optimistic updates?

JakeSidSmith avatar Jun 22 '20 10:06 JakeSidSmith

Yes, I see it eventually goes away. But I think you can know when the notification is clicked, in which case you might as well remove that item from the list. From a UX perspective it is expected.

aparajita avatar Jun 22 '20 10:06 aparajita