training-manual icon indicating copy to clipboard operation
training-manual copied to clipboard

Fix urls

Open amyschoen opened this issue 4 years ago ā€¢ 11 comments

Fixing hard-coded URLs in preparation for the OSS release.

Closes #232

amyschoen avatar Jun 30 '20 14:06 amyschoen

@amyschoen Thank you so much for doing this! āœØ

Everything looks correct, I'd just like to wait until I hear back from @brianamarie regarding the possibility of using a custom domain for this repo before approving the changes: https://github.com/githubtraining/training-manual/issues/232#issuecomment-652108515.

parkerbxyz avatar Jul 01 '20 00:07 parkerbxyz

You're welcome @parkerbxyz, and it makes sense. github.github.io does look a tad odd in the URL.

amyschoen avatar Jul 01 '20 13:07 amyschoen

@brianamarie, @parkerbxyz, @BirdyBigbird, I see my WIP PR got approved. Do we have a date for the repo move yet?

amyschoen avatar Sep 28 '20 14:09 amyschoen

Hi @amyschoen, thank you for following up.

At this point, we do not have a date planned for moving and renaming the repository. While it's a move we want to make, the urgency is low and the level of impact is unclear, which makes it harder to prioritize. If there are any reasons or upcoming events that we should be considering, please let us know. šŸ˜Š

In the meantime, thank you for your contributions and for your patience. šŸ™

brianamarie avatar Sep 30 '20 10:09 brianamarie

There aren't any timelines on my part @brianamarie. I'll keep this as a WIP for now so it doesn't accidentally get merged in.

amyschoen avatar Sep 30 '20 14:09 amyschoen

@brianamarie, I've noticed a few approvals lately. Do we have an updated timeline yet for the repo move?

amyschoen avatar Mar 22 '21 13:03 amyschoen

Hi @amyschoen! I am not sure where these approvals are coming from... especially seeing that one is now "ghost", which usually means that account is no longer active.

Unfortunately, I am longer able to look after this initiative as actively. @parkerbxyz, is this something you're shepherding, or would like to shepherd, or is this something we'd consider in the backlog until further notice?

brianamarie avatar Mar 24 '21 09:03 brianamarie

It's still a draft PR, so no worries about this getting merged in before we're ready. I was just surprised to see a couple approvals recently.

amyschoen avatar Mar 24 '21 13:03 amyschoen

@parkerbxyz, is this something you're shepherding, or would like to shepherd, or is this something we'd consider in the backlog until further notice?

This is in the backlog, but on my radar. Iā€™m hoping to find time to revisit this soon! šŸ™‚

parkerbxyz avatar Mar 29 '21 23:03 parkerbxyz

approve-change

herdemu avatar May 14 '21 15:05 herdemu

git commit -m" git 'if there is nan a master plan to solves the following files (script/create-repo and script/reset-game) on (checks) pull safety feature requests to add some (YML) features build file solution examples in (fix_urls).

djibal avatar Jul 07 '21 03:07 djibal