[Feature request] Square brackets ligatures

[shipurjan]

Hello, this font looks amazing but I wish it had square bracket ligatures (for example [] combining into a square)

The font FiraCode has such ligature (cv27)

So are there plans to introduce more ligatures?

[Hanshenggao]

When I set replace_sampler_ddp=False, the problem is solved, is there another way to solve it?

[awaelchli]

@Hanshenggao We recently updated the handling of these cases #18402. You are using an old version of Lightning, so I think upgrading is another option. If you can, please subclass BatchSampler class instead of Sampler, then Lightning can recognize that you are meant to use it as a batch sampler.

If you can't follow that interface, you will have to disable replace_sampler_ddp=False and handle the distributed sampling in your sampler yourself, there is no other way to automate this for Lightning otherwise. I hope this makes somewhat sense.

[Hanshenggao]

@awaelchli Thank you，i will try to subclass BatchSampler class instead of Sampler.If there are still errors, I will upgrade Lightning.Thank you so much

[awaelchli]

@Hanshenggao Did it work?

[Hanshenggao]

@awaelchli I try to subclass batchsampler class, but it can not work.So, i‘m trying to handle the distributed sampling.If it still doesn't work, I'll upgrade pytorch lightning.Many thanks for your attention!

[Hanshenggao]

@awaelchli When I tried to create distributed batchsampler, it can work!Thank you for your answer!Your answer helped me a lot！

[awaelchli]

@Hanshenggao Great you got it to work 🎉 Does that mean we should close the issue, or is there something left to action? The error message regarding this should already be improved in Lightning >= 2.1+, and users need to add distributed support in custom samplers anyway.