monaspace icon indicating copy to clipboard operation
monaspace copied to clipboard

Left shift and right shift assignment operators rendered wrong

Open LeoVasanko opened this issue 2 years ago • 2 comments

A fairly common operator <<= in C and other languages is misrendered as < followed by (when ss2 or dlig is enabled). Similarly, right shift assignement >>= is misrendered as > and .

There should be ligatures to handle the shift assignment operators <<= and >>= with higher precedence than the <= or >= part of it as comparison.

LeoVasanko avatar Nov 30 '23 09:11 LeoVasanko

⚡ Required checks status: All passing 🟢

Groups summary

🟢 lightning_data: CPU workflow
Check ID Status
data-cpu (macOS-11, lightning, 3.10, 2.1) success
data-cpu (ubuntu-20.04, lightning, 3.10, 2.1) success
data-cpu (windows-2022, lightning, 3.10, 2.1) success

These checks are required after the changes to requirements/data/test.txt, src/lightning/data/processing/__init__.py, src/lightning/data/processing/image.py, src/lightning/data/processing/readers.py, src/lightning/data/streaming/data_processor.py, src/lightning/data/streaming/functions.py, tests/tests_data/processing/__init__.py, tests/tests_data/processing/test_readers.py.

🟢 mypy
Check ID Status
mypy success

These checks are required after the changes to requirements/data/test.txt, src/lightning/data/processing/__init__.py, src/lightning/data/processing/image.py, src/lightning/data/processing/readers.py, src/lightning/data/streaming/data_processor.py, src/lightning/data/streaming/functions.py.

🟢 install
Check ID Status
install-pkg (ubuntu-22.04, app, 3.8) success
install-pkg (ubuntu-22.04, app, 3.11) success
install-pkg (ubuntu-22.04, fabric, 3.8) success
install-pkg (ubuntu-22.04, fabric, 3.11) success
install-pkg (ubuntu-22.04, pytorch, 3.8) success
install-pkg (ubuntu-22.04, pytorch, 3.11) success
install-pkg (ubuntu-22.04, lightning, 3.8) success
install-pkg (ubuntu-22.04, lightning, 3.11) success
install-pkg (ubuntu-22.04, notset, 3.8) success
install-pkg (ubuntu-22.04, notset, 3.11) success
install-pkg (macOS-12, app, 3.8) success
install-pkg (macOS-12, app, 3.11) success
install-pkg (macOS-12, fabric, 3.8) success
install-pkg (macOS-12, fabric, 3.11) success
install-pkg (macOS-12, pytorch, 3.8) success
install-pkg (macOS-12, pytorch, 3.11) success
install-pkg (macOS-12, lightning, 3.8) success
install-pkg (macOS-12, lightning, 3.11) success
install-pkg (macOS-12, notset, 3.8) success
install-pkg (macOS-12, notset, 3.11) success
install-pkg (windows-2022, app, 3.8) success
install-pkg (windows-2022, app, 3.11) success
install-pkg (windows-2022, fabric, 3.8) success
install-pkg (windows-2022, fabric, 3.11) success
install-pkg (windows-2022, pytorch, 3.8) success
install-pkg (windows-2022, pytorch, 3.11) success
install-pkg (windows-2022, lightning, 3.8) success
install-pkg (windows-2022, lightning, 3.11) success
install-pkg (windows-2022, notset, 3.8) success
install-pkg (windows-2022, notset, 3.11) success

These checks are required after the changes to src/lightning/data/processing/__init__.py, src/lightning/data/processing/image.py, src/lightning/data/processing/readers.py, src/lightning/data/streaming/data_processor.py, src/lightning/data/streaming/functions.py, requirements/data/test.txt.


Thank you for your contribution! 💜

Note This comment is automatically generated and updates for 60 minutes every 180 seconds. If you have any other questions, contact carmocca for help.

github-actions[bot] avatar Feb 05 '24 17:02 github-actions[bot]