Every character except for the letters, accents and bigger numbers look like Neon's

[Bronnel721]

I'm testing it out with Radon because it's my favorite, but the characters that don't fit the handwritten style look the exact same in ALL fonts: https://github.com/githubnext/monaspace/assets/92538982/491f1ce4-2225-4816-bc1a-ce758cbc6e04

[Aditi840]

@Borda, do I need to change some more files or this much is ok.

[Aditi840]

@Borda please answer, do I need to change some more files or this much is ok.

[Borda]

@Borda please answer, do I need to change some more files or this much is ok.

pls check the failing tests

[Aditi840]

@Borda there is an error which says.This job will need to be re-run to merge your PR. If you do not have write access to the repository you can ask Lightning-AI/lai-frameworks to re-run it for you. If you have any other questions, you can reach out to carmocca for help.

[Borda]

@Borda there is an error which says.This job will need to be re-run to merge your PR. If you do not have write access to the repository you can ask Lightning-AI/lai-frameworks to re-run it for you. If you have any other questions, you can reach out to carmocca for help.

I see many more failing, for example:

• https://github.com/Lightning-AI/lightning/actions/runs/5963502249/job/16176829106?pr=18382
• https://github.com/Lightning-AI/lightning/actions/runs/5963502251/job/16176831776?pr=18382
• https://github.com/Lightning-AI/lightning/actions/runs/5963502237/job/16176826628?pr=18382

[Aditi840]

@Borda in first example, its saying type error an integer is required (got type str) and AssertionError:

assert '/tmp/pytest-of-runner/pytest-0/test_file_logger_no_name__0' == PosixPath('/tmp/pytest-of-runner/pytest-0/test_file_logger_no_name__0')                  In second example, AttributeError: 'PosixPath' object has no attribute 'write'
loggers/test_logger.py:337: AttributeError, AttributeError: 'PosixPath' object has no attribute 'listdir', AssertionError: assert '/tmp/pytest-of-runner/pytest-0/test_simple_profiler_with_none0/nonexisting' == PosixPath('/tmp/pytest-of-runner/pytest-0/test_simple_profiler_with_none0/nonexisting')
E        +  where '/tmp/pytest-of-runner/pytest-0/test_simple_profiler_with_none0/nonexisting' = <lightning.pytorch.trainer.trainer.Trainer object at 0x7fef0fa7a790>.log_dir
profilers/test_profiler.py:131: AssertionError, AttributeError: 'PosixPath' object has no attribute 'join', and so many assertion errors, In third example, AttributeError: 'PosixPath' object has no attribute 'join', E           AssertionError: expected call not found.
E           Expected: put('file', PosixPath('/tmp/pytest-of-runner/pytest-0/test_copier_copies_all_files0/.shared/123'))
E           Actual: put('file', '/tmp/pytest-of-runner/pytest-0/test_copier_copies_all_files0/.shared/123')

/opt/hostedtoolcache/Python/3.8.17/x64/lib/python3.8/unittest/mock.py:913: AssertionError, , and many more attribute errors

[awaelchli]

@Aditi840 I propose that we break this effort into smaller junks. As you can see, we can't just "find+replace" tmpdir with tmp_path, because they are not functionally equivalent in all cases. That means some tests will need a slight update in the code, so whoever works on this will have to look at each test failure individually and fix it.

Since this requires a bit of work, and there are many occurrences, I suggest that we do it in smaller pieces. It will also reduce the chance of merge conflict and should make your life easier too. Let me know what you think.

[Aditi840]

@awaelchli Good Idea, let's spilt the work then.

[Borda]

@Aditi840 I propose that we break this effort into smaller junks.

already suggested in the original issue so we can track it there: https://github.com/Lightning-AI/lightning/issues/16188#issuecomment-1691189400

[Aditi840]

@Borda , please tell me your slack id

[Aditi840]

@awaelchli, lets split it, and tell me what needs to be done by my side.

[Borda]

@Borda , please tell me your slack id

You can find me as Jirka :) I made a sample partial fix, so based on partitions in https://github.com/Lightning-AI/lightning/issues/16188#issuecomment-1691189400, I just chose a topic/folder and tried to apply changes...

1. chose one folder and create a draft PR (which can be almost empty) that we can link the issues
2. take it file by file and perform replacement
3. I would suggest each file change shall be one commit in the PR so it is easier to trace what changes are not compatible

[gitguardian[bot]]

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request

GitGuardian id	Secret	Commit	Filename
-	Generic High Entropy Secret	78fa3afdfbf964c19b4b2d36b91560698aa83178	tests/tests_app/utilities/test_login.py	View secret
-	Base64 Basic Authentication	78fa3afdfbf964c19b4b2d36b91560698aa83178	tests/tests_app/utilities/test_login.py	View secret

🛠 Guidelines to remediate hardcoded secrets

1. Understand the implications of revoking this secret by investigating where it is used in your code.
2. Replace and store your secret safely. Learn here the best practices.
3. Revoke and rotate this secret.
4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider

• following these best practices for managing and storing secrets including API keys and other credentials
• install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.

---

<sup>🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!</sup>