githubnemo

@cmb-code I don't think this has anything to do with PEFT. If you remove the `no_speech_threshold` option the example will work. I'm not familiar enough with the Whisper implementation to...

Hey, thanks for the suggestion, at the first glance this looks promising. We're currently in the process of deciding how to implement such variations, starting with [SineLoRA](https://github.com/huggingface/peft/issues/2434#issuecomment-2740943926). We'll get back...

I think this is complete. :) Thanks again @PaulAlbert31 for your time and excellent work! It is much appreciated.

*Not stale*

Hi, thanks for taking an interest in Conv1d support for DoRA. We're currently refactoring how LoRA variations such as DoRA are implemented (https://github.com/huggingface/peft/pull/2443). Once this is done we can think...

#2443 is now merged. With the new abstraction in place, it should be easier than before to add support for `nn.Conv1d`. Are you interested in taking this @EskildAndersen?

This should be done with https://github.com/huggingface/peft/pull/2531. Closing. Thanks!

I experimented with this a bit and there are some questions (e.g., https://github.com/reeceshuttle/intruder-dimensions/issues/3). I think whatever implementation it takes, we'll need some experiments to back up that it actually does...

Small update: I have attempted a crude test regarding whether to use `dW` or `W + dW` and I think the answer is to take `dW`. When using `dW` to...

Thanks for investigating! If I understand correctly there's almost no time penalty for using the more correct (recompilation) variant, so I'd opt for that since dropout is only one potential...