task-lists-element icon indicating copy to clipboard operation
task-lists-element copied to clipboard

Published 20 hours ago • verified publisher icon github

Update logic for determining list position

Open nicolleromero opened this issue 2 years ago • 1 comments

Fixes https://github.com/github/issues-graph/issues/825

This PR adjusts the logic used to calculate the positioning of lists within a comment to satisfy additional ul and ol usage.

See linked issue for additional context.

nicolleromero avatar Aug 25 '22 03:08 nicolleromero

You may want to double-check these combos:

  • Nested tasklists
  • Nested mixes of checklists and tasklists
  • Tasklists/checklists within HTML tables (not MD tables)
  • Nested tasklists within HTML tables

mr-mig avatar Aug 25 '22 11:08 mr-mig

You may want to double-check these combos:

  • Nested tasklists
  • Nested mixes of checklists and tasklists
  • Tasklists/checklists within HTML tables (not MD tables)
  • Nested tasklists within HTML tables

Tested the above to confirm that no functionality was lost. The current implementation of a tasklist remains encapsulated so shouldn't be adversely affected by the new positioning logic when support for nesting w/in tasklists is added. 👍

nicolleromero avatar Aug 25 '22 18:08 nicolleromero