rally
rally copied to clipboard
github
Checks "more details" link should link to Rally
Is your feature request related to a problem? Please describe. As a user, when I see a link at the bottom of my Checks summary, which says "View more details on Rally App", I expect that link to take me to Rally, instead of the source code of the GitHub app.
Describe the solution you'd like
Setting details_url on the Checks Run object to point to the most specific location in Rally possible (e.g. Artifact, Project, etc, falling back to the Rally dashboard).
This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.
If you think this issue should stay open, please remove the O: stale 🤖 label or comment on the issue.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
This is not something that can be achieved. The link that is generated at the bottom is part of the GitHub App installation. It's not customizable and is generated from the Homepage URL field in the GitHub App details.
@primetheus The link is settable in the API call:
It's just not being set currently.
Just needs to be added to the GitHub Checks API call you make here: https://github.com/github/rally/blob/668b9c180b3b6c3712ca227a31e46820cc02addd/lib/RallyValidate.js#L536 and in other places
See reference at https://docs.github.com/en/free-pro-team@latest/rest/reference/checks
Ah, right. @ineffyble in the event that you have multiple Rally artifacts in the check, what would be the desired endpoint? For example, if a pull request addresses US8 and DE22, what should the link redirect users to?
This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.
If you think this issue should stay open, please remove the O: stale 🤖 label or comment on the issue.
@primetheus If there's a way to redirect to the a page showing a list of those artifacts (possibly by searching for "US8 OR DE22" or such), that would be ideal. Otherwise the first artifact would be fine I think.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.
If you think this issue should stay open, please remove the O: stale 🤖 label or comment on the issue.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.
If you think this issue should stay open, please remove the O: stale 🤖 label or comment on the issue.
There is a case that we need to consider
If commentOnPull: false then the status check url should show the results of the report. Otherwise we won't have any other way to see it?
