platform-samples
platform-samples copied to clipboard
Add checkpoint feature to find_inactive_members.rb
Script find_inactive_members.rb
sometimes breaks while parsing large organization either caused by timeout or connection error.
Checkpoint flag --checkpoint
helps by storing Octokit API responses as json files in data/
, so that during re-run it will first try to use stored json files instead of calling Github API from the beginning.
Hi @asendia. I like this idea, and I have run into the problem that you are describing myself.
What help do you need to get this PR over the finish line? Do you need a review, or something else?
I would also support this change and merge it once it has been tested by somebody else like @spier . I resolved the conflicts to upstream to the best of my knowledge already.
I will try this out locally, and leave comments on this PR.
I was wondering if instead of creating a custom caching solution, one could also use something like http://octokit.github.io/octokit.rb/#Caching instead? Don't have time right now to try it unfortunately, but maybe over the weekend.
I was wondering if instead of creating a custom caching solution, one could also use something like http://octokit.github.io/octokit.rb/#Caching instead? Don't have time right now to try it unfortunately, but maybe over the weekend.
I am not too familiar with ruby as you can see from the code in my PR 🙇
My reasons:
- If we use eTag based cache it will still call github API during retry and it will still eat the request bandwidth.
- Does that cache persist after the script closes? When I used this script I experienced few numbers of unknown errors that made the script force closed.
CMIIW