pages-gem icon indicating copy to clipboard operation
pages-gem copied to clipboard

Whitelist jekyll-data plugin

Open yatil opened this issue 5 years ago • 8 comments

In lieu of a proper translation solution (#401), can we at least make data in themes portable by whitelisting https://github.com/ashmaroli/jekyll-data. Keeping data that belongs to the theme (like common navigation or translation phrases) in sync is really complicated at the moment. This would be a relatively simple solution.

yatil avatar Dec 21 '18 08:12 yatil

I have asked for similar functionality. Either this or just make it part of the solution; it can work just like _includes and other folders where if the pages using the theme override _data/somefile.yml, for instance then the pages one is used instead of the theme one.

hblankenship avatar Jan 28 '21 20:01 hblankenship

Yep, this would be really useful, e.g. to maintain a consistent navigation menu when a site is built by composing the gh pages of multiple gh repos.

Currently, I have to keep data files synchronised across 20 odd repos. A right PITA! ;)

big-andy-coates avatar Nov 12 '22 11:11 big-andy-coates

Related to https://github.com/benbalter/jekyll-remote-theme/issues/68

big-andy-coates avatar Nov 12 '22 13:11 big-andy-coates

We upstreamed theme data folder propagation to Jekyll: https://github.com/jekyll/jekyll/pull/8815

I believe this repo is in maintenance mode. GitHub Actions now has first-class support for Pages, so I'd recommend setting that up for affected repos if you can.

parkr avatar Nov 12 '22 19:11 parkr

Use Jekyll v4.3.0 or later. Full release notes (including the above linked PR): https://github.com/jekyll/jekyll/releases/tag/v4.3.0

parkr avatar Nov 12 '22 19:11 parkr

Thanks!

On Sat, 12 Nov 2022 at 19:50, Parker Moore @.***> wrote:

Use Jekyll v4.3.0 or later. Full release notes (including the above linked PR): https://github.com/jekyll/jekyll/releases/tag/v4.3.0

— Reply to this email directly, view it on GitHub https://github.com/github/pages-gem/issues/610#issuecomment-1312559262, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB5EE3QPXRX75DOK4IOMS5LWH7YHJANCNFSM4GLWMQJQ . You are receiving this because you commented.Message ID: @.***>

big-andy-coates avatar Nov 13 '22 10:11 big-andy-coates

A bit of Googling on this seems to suggest that this involves switching to a workflow to build the docs, and it may well be the case that the thème I'm using isn't compatible with Jekyll 4.x.

I'm a Ruby / Jekyll noob, and the upgrade is daunting.

I'm therefore wondering if this whitelisting would enable the required functionally without the need to switch to workflow or finding a Jekyll 4.x theme.

Thoughts @parkr ?

big-andy-coates avatar Nov 13 '22 13:11 big-andy-coates

@big-andy-coates The Jekyll v4 upgrade isn't that big actually – the reason I never got around to it while I worked at GitHub was because there was a breaking change in post_url which would have silently broken millions of sites. But if you're doing the upgrade yourself, you can check on links throughout the site to ensure they're correct. Jekyll even has upgrading docs: https://jekyllrb.com/docs/upgrading/3-to-4/

I don't work for GH anymore but from what I gather on their blog, Actions is The Future ™️ so they're likely not accommodating the security review and maintenance of additional plugins at this time. I can't say for sure though, but if I were you, I'd migrate to an (Actions) workflow and have full customizability. :)

parkr avatar Nov 14 '22 18:11 parkr