github
Add Hubot Sans - PR n°1
Hi @tobiasahlin! cc @eweracs
I fixed the biggest part of the fontbakery fails. For this, I:
- updated the config.yaml
- renamed masters
- added an axis mapping (the values 80 and 120 don't follow the specs, for the user values of the width instances, so I preferred to add an axis mapping parameter, it's easier)
- added the OFL.txt
Also, we are currently moving to another way of doing the name table. Currently, for more complex variable font like this one, the name ID1 is composed of the family name + origin instance name, giving some very long names in some cases. This will change, to have only the family name in the name ID1. For now, I updated the name table manually on the binaries, thanks to ttx. If we need to re-export the fonts, I'll update it again.
In that PR, I took the changes of Sebastien also, you can now merge everything on the main branch. Please let me know if the exports are ok for you. Some fails are still there, but it's ok, it's because there are no "normal" master for the width, and it's ok to ignore that.
Also, we prefer to have a conventional notdef sign. Please read this, and let me know if it's ok to change it:https://github.com/fonttools/fontbakery/issues/4770 If not, we can discuss about a solution! :)
Finally, I spotted an issue in the circled numbers. I think it's because of some nested components. Please have a look!
Once it's corrected, I'll re-export + ttx the name table, and we should be good :)
Let me know if you have any questions!
Cheers ☀️
Please don't merge that PR yet, we are still in discussion to know what approach to use for the name table. I'll let you know
@tobiasahlin @eweracs Hey! We decided to move on, and if there are anything to change later, I'll let you know!
You can now merge that PR! thank you :)
Waiting on the review / merge of this PR to continue onboarding in Google Fonts
