v1.1

Open tobiasahlin opened this issue 1 year ago • 4 comments

Collecting all updates made for v1.1, from https://github.com/github/hubot-sans/pull/31 and https://github.com/github/hubot-sans/pull/31 primarily.

Jun 19 '24 11:06 tobiasahlin

Hi @eweracs & @tobiasahlin!

Yanone will be off this summer, so it's my time to take a look to the project :)

Like Mona Sans, we will need fonts that follow the GF specs (you can separate them in a folder called googlefonts/ if you want). For now, I exported the fonts with gftools builder config.yaml.

I still see a lot of fails, related to the variable. I think that some of them appear because the masters names are different from the instances. We also need an avar table for the width.

Since I don't see for now any related-design issues, I can do it myself on my fork and send you a PR with the font exported and ready for GF. You can merge these changes in the main branch, I'll fork it then. I just need you confirm if it's ok for you if I change the masters names.

Cheers! ☀️

Here you can find the fontbakery report, I should be able to remove all the fails:

FontBakery report

fontbakery version: 0.12.7

Experimental checks

These won't break the CI job for now, but will become effective after some time if nobody raises any concern.

[1] HubotSans-Italic[wdth,wght].ttf

⚠️ WARN Validate size, and resolution of article images, and ensure article page has minimum length and includes visual assets.

⚠️ WARN
Family metadata at . does not have an article.
[code: lacks-article]

[1] HubotSans[wdth,wght].ttf

⚠️ WARN Validate size, and resolution of article images, and ensure article page has minimum length and includes visual assets.

⚠️ WARN
Family metadata at . does not have an article.
[code: lacks-article]

All other checks

[27] HubotSans-Italic[wdth,wght].ttf

💥 ERROR Ensure 'ital' STAT axis is boolean value

💥 ERROR
Failed with AttributeError: 'NoneType' object has no attribute 'AxisValue'

  File "/Users/marichalemma/Google/env/lib/python3.12/site-packages/fontbakery/checkrunner.py", line 213, in _run_check
    subresults = list(subresults)
                 ^^^^^^^^^^^^^^^^
  File "/Users/marichalemma/Google/env/lib/python3.12/site-packages/fontbakery/checks/opentype/stat.py", line 236, in com_google_fonts_check_italic_axis_in_stat_is_boolean
    value, flags, linkedValue = get_STAT_axis_value(ttFont, "ital")
                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/marichalemma/Google/env/lib/python3.12/site-packages/fontbakery/checks/opentype/stat.py", line 224, in get_STAT_axis_value
    for axisValue in font["STAT"].table.AxisValueArray.AxisValue:
                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

[code: failed-check]

🔥 FAIL The variable font 'wdth' (Width) axis coordinate must be 100 on the 'Regular' instance.

🔥 FAIL
The "wdth" axis coordinate of the "Regular" instance must be 100. Got 80.0 as a default value instead.
[code: wdth-not-100]

🔥 FAIL STAT table has Axis Value tables?

🔥 FAIL
STAT table has no Axis Value tables.
[code: no-axis-value-tables]

🔥 FAIL Ensure dotted circle glyph is present and can attach marks.

🔥 FAIL
The following glyphs could not be attached to the dotted circle glyph:

- uni031B

- uni0335

- uni0336

- uni0337

- uni0338

[code: unattached-dotted-circle-marks]

🔥 FAIL Combined length of family and style must not exceed 32 characters.

🔥 FAIL
Variable font instance name 'Hubot Sans ExtraLight ExtraLight Italic' formed by space-separated concatenation of font family name (nameID 1) and instance subfamily nameID 278 exceeds 32 characters.