graphql-client icon indicating copy to clipboard operation
graphql-client copied to clipboard

Error on older Ruby versions (<2.4.0)

Open nirga opened this issue 3 years ago • 1 comments

My team is (unfortunately) using Ruby 2.3.5. When using the library with this version, you get the following exception

undefined method `match?' for /\A[A-Z]/:Regexp

This is due to the method match? being first implemented in Ruby 2.4. The code should add a check and use ~= when match? is not available.

nirga avatar Nov 08 '21 12:11 nirga

Disclaimer: I'm not a maintainer/contributor to this repo, just a passerby cause of https://github.com/github/graphql-client/issues/277.

Just curious, why would your team still be using Ruby 2.3.5? Ruby 2.3.x has been end of life for almost 3 years at this point. Support was dropped on 2019-03-31. While supporting usage of this gem is a fine ideal, to some degree I think it's valid to push the Ruby community forward, at the very least in the name of security.

For reference the oldest, secure, supported version of Ruby is Ruby 2.6.9, which will be end-of-life on 2022-03-31. https://www.ruby-lang.org/en/downloads/branches/

larouxn avatar Dec 09 '21 05:12 larouxn