graphql-client icon indicating copy to clipboard operation
graphql-client copied to clipboard

Published 20 hours ago • verified publisher icon github

Raise QueryError instead of KeyError in GraphQL::Client#dump_schema

Open Enceradeira opened this issue 4 years ago • 2 comments

Hi, When the introcspection endpoint returns a 404 GraphQL::Client#dump_schema raises a KeyError.

This pull request reuses the error-handling from GraphQL::Client#query in dump_schema to properly handle errors. If an error is detected dump_schema raises a QueryError now.

Could you please merge into into master? This PR replaces an earlier one which had a merge conflict.

Regards Jorg

Enceradeira avatar Jan 18 '21 11:01 Enceradeira

Please accept/reject or comment on my PR. I would like to eliminate my cloned repo/gem soon. Thanks! If it's unlikely you'll accept my PR please say so.

Enceradeira avatar Oct 13 '21 11:10 Enceradeira

@arthurschreiber ,

I think @Enceradeira has got a valid point there. Would you mind checking his PR?

Kind regards, Reureu

reureu avatar May 25 '22 07:05 reureu