gitignore icon indicating copy to clipboard operation
gitignore copied to clipboard

Update VS Code (remove a path and add a missing one)

Open FurkanKambay opened this issue 1 year ago • 2 comments

Reasons for making this change:

  • Removes a 3rd party extension directory (.history/) because of reasons described below.
  • Adds the *.code-workspace path that exists in https://github.com/github/gitignore/blob/main/VisualStudio.gitignore#L385 and https://github.com/github/gitignore/blob/main/Global/AL.gitignore#L6. (They should also be updated with the missing !.vscode/*.code-snippets that exists here. I can open PRs when this is merged)

Links to documentation supporting these rule changes:

The .history/ directory is only used by this third party extension which has already been stated in https://github.com/github/gitignore/pull/3008#issue-423274609. Moreso, VS Code has since officially released their own 'local history' feature which doesn't use such a directory: release notes

FurkanKambay avatar Jul 28 '23 18:07 FurkanKambay

Visual Studio Code's *.code-workspace is intended to contain workspace-specific configurations for VSCode and its extensions. It can contain user-specific values, but is intended for sharing settings, tasks, and more between contributors—just like the JSON files already whitelisted. It's comparable to Visual Studio's *.sln files. https://code.visualstudio.com/docs/editor/workspaces

Why does VisualStudio.gitignore contain Visual Studio Code rules, anyway?

BinToss avatar Sep 16 '23 20:09 BinToss

@BinToss you're right, I guess I just blindly copied it.

And for your question, the answer is in #3722:

Our customer research supports that we have lots of developers using multiple tools, primarily VS and Code together. Ensuring that we have one VS family that encapsulate them is convenient for the developers and saves them a step and has been requested.

We think of VS as a family of products and something that represents VS, should be inclusive of this.

Albeit undesirable, I think it was just needed.

FurkanKambay avatar Sep 17 '23 08:09 FurkanKambay