gitignore icon indicating copy to clipboard operation
gitignore copied to clipboard

Added target directory to Git exclusion list

Open DaManDOH opened this issue 3 years ago • 7 comments

Reasons for making this change:

target directory is not included in the NetBeans.gitignore template file.

Links to documentation supporting these rule changes:

Made a new Java Maven project under NetBeans 16. Build files were saved in target directory.

DaManDOH avatar Dec 21 '22 21:12 DaManDOH

Do I need more approvals for the github/gitignore repo's maintainers to accept this PR?

DaManDOH avatar Jan 18 '23 14:01 DaManDOH

This PR is stale because there have been no updates in 90 days. It will close after 180 days of inactivity. Leave a comment if you want to keep it open :smile:

github-actions[bot] avatar Jun 08 '25 16:06 github-actions[bot]

Wow, did the Github bot necro this PR...

DaManDOH avatar Jun 11 '25 16:06 DaManDOH

Wow, did the Github bot necro this PR...

Lol @DaManDOH it did. We recently turned on StaleBot in order to try and get the open PRs to a maintainable state. Do you still need this PR to be reviewed?

thorrsson avatar Jun 11 '25 19:06 thorrsson

My personal use case is OBE, but it's a pretty minor commit.

DaManDOH avatar Jun 11 '25 22:06 DaManDOH

@DaManDOH Could you provide some more docs explaining what this directory is and why it should be excluded?

wirecat avatar Jun 13 '25 21:06 wirecat

As best I can recall, it was a conventional directory for Netbean's config of Maven's resultant binaries/deployables/temporals. However, this PR is about 2.5 years old. 😅

DaManDOH avatar Jun 13 '25 21:06 DaManDOH

@DaManDOH I hear that. Doing my best to not let PRs sit that long again 🤞. Without some docs I can't accept the change. Up to you if you'd like to dig those up or close this PR for now.

wirecat avatar Jun 20 '25 20:06 wirecat

@DaManDOH I hear that. Doing my best to not let PRs sit that long again 🤞. Without some docs I can't accept the change. Up to you if you'd like to dig those up or close this PR for now.

Completely understood. Heck, this was in response to something Netbeans v16 was doing and it's up to v26. Seems Apache adopted Oracle's Java versioning cadence.

Closing this PR.

DaManDOH avatar Jun 23 '25 15:06 DaManDOH