gh-ost icon indicating copy to clipboard operation
gh-ost copied to clipboard

Published 20 hours ago • verified publisher icon github

Use arm package to install go on raspberry pi

Open bancer opened this issue 6 years ago • 6 comments

Related issue: https://github.com/github/gh-ost/issues/730

Description

Updates script/ensure-go-installed script for Raspberry Pi. I was not sure about bumping up PREFERRED_GO_VERSION for other OS.

bancer avatar Apr 18 '19 16:04 bancer

@shlomi-noach Could this be merged?

bancer avatar Apr 23 '19 14:04 bancer

Thank you, I've been out of office. I'll catch up with this in a couple days.

shlomi-noach avatar Apr 29 '19 05:04 shlomi-noach

Two things that concern me:

  • This is not tested
  • If it were tested, it would currently fail, since go1.11 uses different go fmt output than go1.9, something that is enforced by tests.

I'm still unsure how I feel about this. I appreciate that it would be nice to deliver non-linux build capabilities; but as soon as this is merged I would need to own those builds, which I will not be able to support.

shlomi-noach avatar Apr 30 '19 11:04 shlomi-noach

Understood. I tried to set up tests but faced the same problem as reported in this issue. Are there any instructions or recommendations how to configure gh-ost-test-mysql-master and gh-ost-test-mysql-replica servers? MySQL-Sandbox seems to be deprecated so I think about using DBdeployer.

The lowest *.linux-armv6l.tar.gz package version available on https://storage.googleapis.com/golang/ is 1.10.1. Would that be better?

bancer avatar Apr 30 '19 11:04 bancer

Please see http://code.openark.org/blog/mysql/using-dbdeployer-in-ci-tests as for how we run (non-public facing) CI tests with dbdeployer. The repos and the code are public, but the tests themselves run internally at GitHub.

shlomi-noach avatar Apr 30 '19 12:04 shlomi-noach

@bancer I think this is safe to integrate. Could you update this PR branch?

timvaillancourt avatar Feb 25 '22 18:02 timvaillancourt