gh-ost icon indicating copy to clipboard operation
gh-ost copied to clipboard
verified publisher icon github

Binlog compress

Open fulldb opened this issue 1 year ago • 2 comments

A Pull Request should be associated with an Issue.

We wish to have discussions in Issues. A single issue may be targeted by multiple PRs. If you're offering a new feature or fixing anything, we'd like to know beforehand in Issues, and potentially we'll be able to point development in a particular direction.

Related issue: https://github.com/github/gh-ost/issues/884

Further notes in https://github.com/github/gh-ost/blob/master/.github/CONTRIBUTING.md Thank you! We are open to PRs, but please understand if for technical reasons we are unable to accept each and any PR

Description

This PR [briefly explain what it does]

In case this PR introduced Go code changes:

  • [ ] contributed code is using same conventions as original code
  • [ ] script/cibuild returns with no formatting errors, build errors or unit test errors.

fulldb avatar Sep 05 '24 02:09 fulldb

Related issue: https://github.com/github/gh-ost/issues/884

support enabled this parameter binlog_transaction_compression support binlog_transaction_compression =on

fulldb avatar Sep 05 '24 03:09 fulldb

@fulldb thanks for this great contribution! Is it possible to add a unit test that confirms this behaviour?

Preferably this would validate a compressed row event ends up as an event we expect

timvaillancourt avatar Oct 01 '24 21:10 timvaillancourt