gh-ost icon indicating copy to clipboard operation
gh-ost copied to clipboard

fix: because lock is not release, drop cutover sentry table is hanged

Open lmtwga opened this issue 2 years ago • 2 comments

Related issue: https://github.com/github/gh-ost/issues/1171

lmtwga avatar Sep 16 '22 09:09 lmtwga

@dm-2 Please review when you have time. Thank you very much!

lmtwga avatar Sep 16 '22 09:09 lmtwga

@dm-2 @timvaillancourt Please review when you have time. Thank you very much!

lmtwga avatar Sep 22 '22 11:09 lmtwga

The problem and the fix make sense to me :+1:

@timvaillancourt would you mind taking a look as well? 🙇 Your thoughts would be much appreciated, given that it's such a critical section of code!

dm-2 avatar Oct 21 '22 16:10 dm-2

Hey @dm-2; I just got hit with this bug as well and I would love to get this or some related fix merged -- would you mind if I took a look and did some testing on this PR to validate?

gtowey-air avatar Jan 26 '23 19:01 gtowey-air

@rashiq @dm-2 I've tested this PR and it looks like it fixes the problem. I recommend that we go ahead and merge this!

gtowey-air avatar Jan 27 '23 23:01 gtowey-air

@timvaillancourt would you mind taking a look as well?

Sorry for the delay, this LGTM 👍

timvaillancourt avatar Jan 27 '23 23:01 timvaillancourt

@rashiq Thanks for the approval! Would you be able to merge this?

gtowey-air avatar Jan 31 '23 19:01 gtowey-air

@gtowey-air Hey! (also nice to see you again!) - sorry for the delay, merging now

rashiq avatar Feb 06 '23 13:02 rashiq