gh-gei icon indicating copy to clipboard operation
gh-gei copied to clipboard

Add --lfs-mapping-file cli option

Open robandpdx opened this issue 3 years ago • 3 comments

This change will address #540. This change allows a user to pass in a sha mapping file produced during lfs migration. Users can add the --lfs-mapping-file option to specify the mapping file. During the migration, the mapping file shall be used to update the PR SHAs according to the mapping.

  • [x] Did you write/update appropriate tests
  • [ ] Release notes updated (if appropriate)
  • [ ] Appropriate logging output
  • [x] Issue linked
  • [ ] Docs updated (or issue created)

robandpdx avatar Aug 10 '22 00:08 robandpdx

Unit Test Results

549 tests   549 :heavy_check_mark:  2m 15s :stopwatch:     1 suites      0 :zzz:     1 files        0 :x:

Results for commit 43690276.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar Aug 10 '22 00:08 github-actions[bot]

@dylan-smith @ArinGhazarian @robandpdx - What are the next steps to get this PR completed?

roferg avatar Aug 18 '22 20:08 roferg

Code Coverage

Package Line Rate Branch Rate Complexity Health
gei 87% 87% 395
ado2gh 88% 84% 495
bbs2gh 73% 65% 261
Octoshift 90% 78% 774
Summary 87% (5182 / 5975) 80% (1155 / 1448) 1925

github-actions[bot] avatar Sep 19 '22 17:09 github-actions[bot]

@roferg What is needed to get this merged?

robandpdx avatar Sep 27 '22 18:09 robandpdx

This looks nice! Having a smooth LFS experience in GEI would be very beneficial to a bunch of the customers I work with.

RobotKrabs avatar Sep 28 '22 18:09 RobotKrabs

@roferg What is needed to get this merged?

@robandpdx - I'm actually rolling off being the migrations PM and onto another project. @timrogers will be the new PM for migrations moving forward. You should work with him and @dylan-smith to get this over the finish line. Note, @dylan-smith is OOO this week and will be back next week.

roferg avatar Sep 28 '22 22:09 roferg

Closing this because it's super stale. If the team decides to pick it back up we can always re-open.

dylan-smith avatar May 13 '23 18:05 dylan-smith