gh-gei icon indicating copy to clipboard operation
gh-gei copied to clipboard

Provides a mechanism to "lock" a source GH repo (#2)

Open pmartindev opened this issue 3 years ago • 5 comments

Issue #385

Added a flag to allow for archiving the source repository before migration. This will allow migration users to block any changes to their repositories that would normally not be included in the migration. Looking for any feedback and discussion on the issue.

  • [X] Did you write/update appropriate tests
  • [ ] Release notes updated (if appropriate)
  • [X] Appropriate logging output
  • [X] Issue linked
  • [ ] Docs updated (or issue created)

pmartindev avatar Jun 02 '22 17:06 pmartindev

cc: @tj-cappelletti @cvega

pmartindev avatar Jun 02 '22 17:06 pmartindev

Unit Test Results

480 tests   480 :heavy_check_mark:  30s :stopwatch:     1 suites      0 :zzz:     1 files        0 :x:

Results for commit e30c0725.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar Jun 02 '22 18:06 github-actions[bot]

I think this should be implemented as a separate lock-repo command to be consistent with the design already established in ado2gh lock-repo. There is an issue for this improvement with some guidance on design here: https://github.com/github/gh-gei/issues/385

dylan-smith avatar Jun 02 '22 21:06 dylan-smith

Hey @dylan-smith, sorry I linked the wrong issue in the comment 😭 It's corrected now.

pmartindev avatar Jun 03 '22 14:06 pmartindev

Code Coverage

Package Line Rate Branch Rate Complexity Health
gei 88% 84% 432
ado2gh 89% 83% 541
Octoshift 87% 76% 492
Summary 88% (4526 / 5131) 82% (936 / 1147) 1465

github-actions[bot] avatar Jun 17 '22 22:06 github-actions[bot]

A better implementation would be to add the lock_repositories boolean to the StartMetadataArchiveGeneration function and use it in the options object there. Similar to skipRelease boolean. https://github.com/github/gh-gei/blob/main/src/Octoshift/GithubApi.cs#L461-L476

robandpdx avatar Aug 19 '22 21:08 robandpdx

Superseded by #589

dylan-smith avatar Sep 09 '22 19:09 dylan-smith