gh-gei icon indicating copy to clipboard operation
gh-gei copied to clipboard

Fixed the Validation for bbs-shared-home and archive-path

Open AakashSuresh2003 opened this issue 9 months ago • 3 comments

This PR refines the validation for BbsSharedHome and ArchivePath inputs.

Validation Enhancements:

  • Validated that the BbsSharedHome directory exists if provided and ArchivePath is not set.
  • Ensured that the ArchivePath file exists if provided.

  • [x] Did you write/update appropriate tests
  • [ ] Release notes updated (if appropriate)
  • [x] Appropriate logging output
  • [x] Issue linked
  • [x] Docs updated (or issue created)
  • [ ] New package licenses are added to ThirdPartyNotices.txt (if applicable)

AakashSuresh2003 avatar Mar 04 '25 10:03 AakashSuresh2003

Unit Test Results

869 tests   869 ✅  20s ⏱️   1 suites    0 💤   1 files      0 ❌

Results for commit 58bf2900.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar Mar 04 '25 10:03 github-actions[bot]

Code Coverage

Package Line Rate Branch Rate Complexity Health
gei 81% 73% 596
ado2gh 84% 78% 631
bbs2gh 82% 76% 681
Octoshift 87% 74% 1403
Summary 84% (7200 / 8549) 75% (1685 / 2246) 3311

github-actions[bot] avatar Mar 06 '25 09:03 github-actions[bot]

PR Summary:

This PR refines the validation for BbsSharedHome and ArchivePath inputs.

Validation Enhancements:

  • Validated that the BbsSharedHome directory exists if provided and ArchivePath is not set.
  • Ensured that the ArchivePath file exists if provided.

Unit Tests:

  • Added unit tests to verify that no exception is thrown when:
    • BbsSharedHome exists.
    • ArchivePath exists.
    • Both BbsSharedHome and ArchivePath are valid.

AakashSuresh2003 avatar Mar 06 '25 09:03 AakashSuresh2003