gh-gei
gh-gei copied to clipboard
Fixed the Validation for bbs-shared-home and archive-path
This PR refines the validation for BbsSharedHome and ArchivePath inputs.
Validation Enhancements:
- Validated that the
BbsSharedHomedirectory exists if provided andArchivePathis not set. - Ensured that the
ArchivePathfile exists if provided.
- [x] Did you write/update appropriate tests
- [ ] Release notes updated (if appropriate)
- [x] Appropriate logging output
- [x] Issue linked
- [x] Docs updated (or issue created)
- [ ] New package licenses are added to
ThirdPartyNotices.txt(if applicable)
Unit Test Results
869 tests 869 ✅ 20s ⏱️ 1 suites 0 💤 1 files 0 ❌
Results for commit 58bf2900.
:recycle: This comment has been updated with latest results.
| Package | Line Rate | Branch Rate | Complexity | Health |
|---|---|---|---|---|
| gei | 81% | 73% | 596 | ✔ |
| ado2gh | 84% | 78% | 631 | ✔ |
| bbs2gh | 82% | 76% | 681 | ✔ |
| Octoshift | 87% | 74% | 1403 | ✔ |
| Summary | 84% (7200 / 8549) | 75% (1685 / 2246) | 3311 | ✔ |
PR Summary:
This PR refines the validation for BbsSharedHome and ArchivePath inputs.
Validation Enhancements:
- Validated that the
BbsSharedHomedirectory exists if provided andArchivePathis not set. - Ensured that the
ArchivePathfile exists if provided.
Unit Tests:
- Added unit tests to verify that no exception is thrown when:
BbsSharedHomeexists.ArchivePathexists.- Both
BbsSharedHomeandArchivePathare valid.